From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LNtGq-0002Bd-5C for qemu-devel@nongnu.org; Fri, 16 Jan 2009 13:18:16 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LNtGo-00028j-I2 for qemu-devel@nongnu.org; Fri, 16 Jan 2009 13:18:15 -0500 Received: from [199.232.76.173] (port=49466 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LNtGo-00028V-6c for qemu-devel@nongnu.org; Fri, 16 Jan 2009 13:18:14 -0500 Received: from e33.co.us.ibm.com ([32.97.110.151]:40923) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LNtGn-00013Q-LZ for qemu-devel@nongnu.org; Fri, 16 Jan 2009 13:18:14 -0500 Received: from d03relay04.boulder.ibm.com (d03relay04.boulder.ibm.com [9.17.195.106]) by e33.co.us.ibm.com (8.13.1/8.13.1) with ESMTP id n0GIHDwK020326 for ; Fri, 16 Jan 2009 11:17:13 -0700 Received: from d03av04.boulder.ibm.com (d03av04.boulder.ibm.com [9.17.195.170]) by d03relay04.boulder.ibm.com (8.13.8/8.13.8/NCO v9.1) with ESMTP id n0GIHk6T038460 for ; Fri, 16 Jan 2009 11:17:47 -0700 Received: from d03av04.boulder.ibm.com (loopback [127.0.0.1]) by d03av04.boulder.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n0GIHjNa019818 for ; Fri, 16 Jan 2009 11:17:46 -0700 Subject: RE: [Qemu-devel] [PATCH 3/9] powerpc/kvm: Enable mpic for E500 platform From: Hollis Blanchard In-Reply-To: <0A1FE637C2C7E148B9573BB60CC630E507D06B@zch01exm26.fsl.freescale.net> References: <1232022857-2315-1-git-send-email-yu.liu@freescale.com> <1232022857-2315-2-git-send-email-yu.liu@freescale.com> <1232022857-2315-3-git-send-email-yu.liu@freescale.com> <1232022857-2315-4-git-send-email-yu.liu@freescale.com> <496FA926.1040205@codemonkey.ws> <0A1FE637C2C7E148B9573BB60CC630E507D06B@zch01exm26.fsl.freescale.net> Content-Type: text/plain Date: Fri, 16 Jan 2009 12:17:40 -0600 Message-Id: <1232129860.29223.18.camel@slate.austin.ibm.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Liu Yu Cc: kvm-ppc@vger.kernel.org, qemu-devel@nongnu.org On Fri, 2009-01-16 at 13:34 +0800, Liu Yu wrote: > > > -----Original Message----- > > From: Anthony Liguori [mailto:anthony@codemonkey.ws] > > Sent: Friday, January 16, 2009 5:23 AM > > To: qemu-devel@nongnu.org > > Cc: Liu Yu-B13201; kvm-ppc@vger.kernel.org > > Subject: Re: [Qemu-devel] [PATCH 3/9] powerpc/kvm: Enable > > mpic for E500 platform > > > > Liu Yu wrote: > > > The modify is based on original author's method > > > to switch openpic and mpic by static define, > > > like the switch between USE_INTEL_GW80314 and USE_MPCxxx. > > > (Although the support for intel has broken) > > > So they can't be used at the same time. > > > > > > I guess it's not the correct way to do this. > > > but I am not sure is the USE_MPC85xx and openpic are still needed? > > > > > > > Have you tested some of the other (TCG) boards (for instance, > > with the > > debian image Aurelien recently posted)? > > > > You mean test powerpc mac99? No. It doesn't sound like mac99 works right now anyways, so that may not be possible to test. > I only modified few places to the original code. I think it won't be influenced. > But mpic and openpic couldnot work in the same qemu binary with this patch. > If they should both be supported, then I need to modify more. Due to the (artificial) "ppc" vs "ppcemb" split, I'm not sure this is a requirement. The only issue I can see is if there are "ppc" targets (e.g. 970) that use the same[1] MPIC as found on e500, and that is different from and not supported by the current OpenPIC emulation. [1] By "same" I mean "substantially similar". As I understand it, OpenPIC and MPIC are very similar designs, but there are different bugs/quirks to different implementations. So even if e500's MPIC isn't *exactly* the same as 970 chipsets' MPIC, if they're close enough that the code could be shared, it should be. -- Hollis Blanchard IBM Linux Technology Center