From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LOqhd-0005J0-70 for qemu-devel@nongnu.org; Mon, 19 Jan 2009 04:45:53 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LOqhb-0005I6-5B for qemu-devel@nongnu.org; Mon, 19 Jan 2009 04:45:52 -0500 Received: from [199.232.76.173] (port=44671 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LOqha-0005Hz-Pf for qemu-devel@nongnu.org; Mon, 19 Jan 2009 04:45:50 -0500 Received: from mx2.redhat.com ([66.187.237.31]:36302) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LOqha-00076r-AY for qemu-devel@nongnu.org; Mon, 19 Jan 2009 04:45:50 -0500 From: Mark McLoughlin In-Reply-To: <20090116210954.16725.44321.stgit@kvm.aw> References: <20090116210954.16725.44321.stgit@kvm.aw> Content-Type: text/plain Date: Mon, 19 Jan 2009 09:45:36 +0000 Message-Id: <1232358336.5627.21.camel@blaa> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 0/7] qemu:virtio-net: Add MAC and VLAN filtering Reply-To: Mark McLoughlin , qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alex Williamson Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org On Fri, 2009-01-16 at 14:09 -0700, Alex Williamson wrote: > This series adds the ability for the guest to set the virtio-net device > MAC address, a new control virtqueue for setting configuration data from > the guest, and new interfaces making use of the control virtqueue for > setting RX mode options, MAC filter table entries, and VLAN filter bits. > The end result is that the virtio-net device has more of the features of > a realy hardware NIC and can be configured to drop packets the guest > isn't interested in seeing. > > This version incorporates the review comments from Mark McLoughlin, > particularly including much better commit logs, factoring control > commands into separate functions, and making a local ETH_ALEN define. > Also new in this version is the addition of VLAN filtering. Please > comment and/or apply. Thanks, > > Alex > > Note - This series depends on the previous patch sent to correct > save and load of the virtio-net state. I think it makes sense to wait for the linux side to be accepted first. It's there the virtio guest ABI is defined, really. Apart from that, the whole series looks good to me: Acked-by: Mark McLoughlin Cheers, Mark.