From: Mark McLoughlin <markmc@redhat.com>
To: qemu-devel@nongnu.org
Cc: ehrhardt@linux.vnet.ibm.com, aliguori@us.ibm.com, borntraeger@de.ibm.com
Subject: Re: [Qemu-devel] [PATCH 1 of 4] kvm-userpace: add virtio-console support
Date: Mon, 19 Jan 2009 10:09:40 +0000 [thread overview]
Message-ID: <1232359780.5627.27.camel@blaa> (raw)
In-Reply-To: <50f40bc14f793a5f4ce6.1231861065@HelionPrime>
On Tue, 2009-01-13 at 16:37 +0100, Christian Ehrhardt wrote:
> + virtio_consoles[0] = "vc:80Cx24C";
> + for(i = 1; i < MAX_VIRTIO_CONSOLES; i++)
> + virtio_consoles[i] = NULL;
> + virtio_console_index = 0;
Hmm, why do we have virtio console enabled by default on x86? Does it
make sense for it to only be available if it's explicitly configured,
except for platforms that don't have serial?
There's a good chance this is going to confuse the hell out of Fedora's
installer, for example. And how does the likes of "virsh console" know
to connect to the virtio console rather than the serial console?
Cheers,
Mark.
next prev parent reply other threads:[~2009-01-19 10:09 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-13 15:37 [Qemu-devel] [PATCH 0 of 4] Add virtio-console support to qemu Christian Ehrhardt
2009-01-13 15:37 ` [Qemu-devel] [PATCH 1 of 4] kvm-userpace: add virtio-console support Christian Ehrhardt
2009-01-15 19:55 ` Anthony Liguori
2009-01-19 10:09 ` Mark McLoughlin [this message]
2009-01-13 15:37 ` [Qemu-devel] [PATCH 2 of 4] kvm-userpace: add virtio-console cmdline option Christian Ehrhardt
2009-01-19 10:11 ` Mark McLoughlin
2009-01-13 15:37 ` [Qemu-devel] [PATCH 3 of 4] kvm-userpace: add virtio-console initializer for x86 Christian Ehrhardt
2009-01-13 15:37 ` [Qemu-devel] [PATCH 4 of 4] kvm-userpace: add virtio-console initializer for powerpc Christian Ehrhardt
2009-01-13 20:27 ` [Qemu-devel] [PATCH 0 of 4] Add virtio-console support to qemu Avi Kivity
2009-01-13 20:34 ` Anthony Liguori
2009-01-13 20:39 ` Avi Kivity
2009-01-13 20:44 ` Anthony Liguori
2009-01-13 20:41 ` Christian Borntraeger
2009-01-13 20:58 ` Avi Kivity
2009-01-13 21:00 ` Avi Kivity
2009-01-15 20:08 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1232359780.5627.27.camel@blaa \
--to=markmc@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=ehrhardt@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).