From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LOr4p-0007Yr-To for qemu-devel@nongnu.org; Mon, 19 Jan 2009 05:09:52 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LOr4o-0007Xg-6P for qemu-devel@nongnu.org; Mon, 19 Jan 2009 05:09:51 -0500 Received: from [199.232.76.173] (port=57422 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LOr4n-0007Xd-VQ for qemu-devel@nongnu.org; Mon, 19 Jan 2009 05:09:50 -0500 Received: from mx2.redhat.com ([66.187.237.31]:42276) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LOr4n-0001qd-E0 for qemu-devel@nongnu.org; Mon, 19 Jan 2009 05:09:49 -0500 Subject: Re: [Qemu-devel] [PATCH 1 of 4] kvm-userpace: add virtio-console support From: Mark McLoughlin In-Reply-To: <50f40bc14f793a5f4ce6.1231861065@HelionPrime> References: <50f40bc14f793a5f4ce6.1231861065@HelionPrime> Content-Type: text/plain Date: Mon, 19 Jan 2009 10:09:40 +0000 Message-Id: <1232359780.5627.27.camel@blaa> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Reply-To: Mark McLoughlin , qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: ehrhardt@linux.vnet.ibm.com, aliguori@us.ibm.com, borntraeger@de.ibm.com On Tue, 2009-01-13 at 16:37 +0100, Christian Ehrhardt wrote: > + virtio_consoles[0] = "vc:80Cx24C"; > + for(i = 1; i < MAX_VIRTIO_CONSOLES; i++) > + virtio_consoles[i] = NULL; > + virtio_console_index = 0; Hmm, why do we have virtio console enabled by default on x86? Does it make sense for it to only be available if it's explicitly configured, except for platforms that don't have serial? There's a good chance this is going to confuse the hell out of Fedora's installer, for example. And how does the likes of "virsh console" know to connect to the virtio console rather than the serial console? Cheers, Mark.