* [Qemu-devel] [PATCH] install man-pages as non-executables
@ 2009-01-19 20:41 Andre Przywara
2009-01-22 17:19 ` Anthony Liguori
0 siblings, 1 reply; 2+ messages in thread
From: Andre Przywara @ 2009-01-19 20:41 UTC (permalink / raw)
To: qemu-devel; +Cc: Andre Przywara
make install-doc omits an explicit permission mask for the man-pages. This
defaults to have the executable bits set. Adding "-m 644" (for rw-r--r--)
fixes that.
Signed-off-by: Andre Przywara <andre.przywara@amd.com>
---
Makefile | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/Makefile b/Makefile
index 8cbdcda..fc7809d 100644
--- a/Makefile
+++ b/Makefile
@@ -233,9 +233,9 @@ install-doc: $(DOCS)
$(INSTALL) -m 644 qemu-doc.html qemu-tech.html "$(DESTDIR)$(docdir)"
ifndef CONFIG_WIN32
mkdir -p "$(DESTDIR)$(mandir)/man1"
- $(INSTALL) qemu.1 qemu-img.1 "$(DESTDIR)$(mandir)/man1"
+ $(INSTALL) -m 644 qemu.1 qemu-img.1 "$(DESTDIR)$(mandir)/man1"
mkdir -p "$(DESTDIR)$(mandir)/man8"
- $(INSTALL) qemu-nbd.8 "$(DESTDIR)$(mandir)/man8"
+ $(INSTALL) -m 644 qemu-nbd.8 "$(DESTDIR)$(mandir)/man8"
endif
install: all $(if $(BUILD_DOCS),install-doc)
--
1.5.2.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] install man-pages as non-executables
2009-01-19 20:41 [Qemu-devel] [PATCH] install man-pages as non-executables Andre Przywara
@ 2009-01-22 17:19 ` Anthony Liguori
0 siblings, 0 replies; 2+ messages in thread
From: Anthony Liguori @ 2009-01-22 17:19 UTC (permalink / raw)
To: qemu-devel; +Cc: Andre Przywara
Andre Przywara wrote:
> make install-doc omits an explicit permission mask for the man-pages. This
> defaults to have the executable bits set. Adding "-m 644" (for rw-r--r--)
> fixes that.
>
> Signed-off-by: Andre Przywara <andre.przywara@amd.com>
>
Applied. Thanks.
Regards,
Anthony Liguori
> ---
> Makefile | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index 8cbdcda..fc7809d 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -233,9 +233,9 @@ install-doc: $(DOCS)
> $(INSTALL) -m 644 qemu-doc.html qemu-tech.html "$(DESTDIR)$(docdir)"
> ifndef CONFIG_WIN32
> mkdir -p "$(DESTDIR)$(mandir)/man1"
> - $(INSTALL) qemu.1 qemu-img.1 "$(DESTDIR)$(mandir)/man1"
> + $(INSTALL) -m 644 qemu.1 qemu-img.1 "$(DESTDIR)$(mandir)/man1"
> mkdir -p "$(DESTDIR)$(mandir)/man8"
> - $(INSTALL) qemu-nbd.8 "$(DESTDIR)$(mandir)/man8"
> + $(INSTALL) -m 644 qemu-nbd.8 "$(DESTDIR)$(mandir)/man8"
> endif
>
> install: all $(if $(BUILD_DOCS),install-doc)
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-01-22 17:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-01-19 20:41 [Qemu-devel] [PATCH] install man-pages as non-executables Andre Przywara
2009-01-22 17:19 ` Anthony Liguori
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).