From: Avi Kivity <avi@redhat.com>
To: Anthony Liguori <anthony@codemonkey.ws>, qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH] Use broadcast address for slirp dhcp replies
Date: Tue, 20 Jan 2009 16:33:31 +0200 [thread overview]
Message-ID: <1232462011-28073-1-git-send-email-avi@redhat.com> (raw)
Windows Vista drops unicast dhcp replies to its yet-unconfigured address,
so use a broadcast address. This behaviour is allowed by the RFC.
Signed-off-by: Avi Kivity <avi@redhat.com>
---
slirp/bootp.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/slirp/bootp.c b/slirp/bootp.c
index bf704ab..ca177f4 100644
--- a/slirp/bootp.c
+++ b/slirp/bootp.c
@@ -191,6 +191,8 @@ static void bootp_reply(struct bootp_t *bp)
rbp->bp_yiaddr = daddr.sin_addr; /* Client IP address */
rbp->bp_siaddr = saddr.sin_addr; /* Server IP address */
+ daddr.sin_addr.s_addr = 0xffffffffu;
+
q = rbp->bp_vend;
memcpy(q, rfc1533_cookie, 4);
q += 4;
--
1.6.0.6
next reply other threads:[~2009-01-20 14:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-20 14:33 Avi Kivity [this message]
2009-01-24 18:16 ` [Qemu-devel] [PATCH] Use broadcast address for slirp dhcp replies Aurelien Jarno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1232462011-28073-1-git-send-email-avi@redhat.com \
--to=avi@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).