From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LQ1t2-0007Nu-LA for qemu-devel@nongnu.org; Thu, 22 Jan 2009 10:54:32 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LQ1t0-0007NQ-KX for qemu-devel@nongnu.org; Thu, 22 Jan 2009 10:54:31 -0500 Received: from [199.232.76.173] (port=36677 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LQ1t0-0007NK-GG for qemu-devel@nongnu.org; Thu, 22 Jan 2009 10:54:30 -0500 Received: from e33.co.us.ibm.com ([32.97.110.151]:58079) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LQ1sz-0004sd-Vc for qemu-devel@nongnu.org; Thu, 22 Jan 2009 10:54:30 -0500 Received: from d03relay02.boulder.ibm.com (d03relay02.boulder.ibm.com [9.17.195.227]) by e33.co.us.ibm.com (8.13.1/8.13.1) with ESMTP id n0MFrRhh018582 for ; Thu, 22 Jan 2009 08:53:27 -0700 Received: from d03av01.boulder.ibm.com (d03av01.boulder.ibm.com [9.17.195.167]) by d03relay02.boulder.ibm.com (8.13.8/8.13.8/NCO v9.1) with ESMTP id n0MFsOrW191580 for ; Thu, 22 Jan 2009 08:54:24 -0700 Received: from d03av01.boulder.ibm.com (loopback [127.0.0.1]) by d03av01.boulder.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n0MFsMl0004367 for ; Thu, 22 Jan 2009 08:54:24 -0700 From: Hollis Blanchard In-Reply-To: <1232619256-18807-7-git-send-email-yu.liu@freescale.com> References: <1232619256-18807-1-git-send-email-yu.liu@freescale.com> <1232619256-18807-2-git-send-email-yu.liu@freescale.com> <1232619256-18807-3-git-send-email-yu.liu@freescale.com> <1232619256-18807-4-git-send-email-yu.liu@freescale.com> <1232619256-18807-5-git-send-email-yu.liu@freescale.com> <1232619256-18807-6-git-send-email-yu.liu@freescale.com> <1232619256-18807-7-git-send-email-yu.liu@freescale.com> Content-Type: text/plain Date: Thu, 22 Jan 2009 09:54:19 -0600 Message-Id: <1232639659.23202.3.camel@slate.austin.ibm.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 6/6] kvm/powerpc: flat device tree files for MPC85xx Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Liu Yu Cc: qemu-devel@nongnu.org, kvm-ppc@vger.kernel.org On Thu, 2009-01-22 at 18:14 +0800, Liu Yu wrote: > > diff --git a/pc-bios/mpc85xx.dts b/pc-bios/mpc85xx.dts > new file mode 100644 > index 0000000..45a9c3d > --- /dev/null > +++ b/pc-bios/mpc85xx.dts > @@ -0,0 +1,361 @@ > +/* > + * MPC85xx DS Device Tree Source > + * > + * Copyright 2007-2009 Freescale Semiconductor Inc. > + * > + * This program is free software; you can redistribute it and/or modify it > + * under the terms of the GNU General Public License as published by the > + * Free Software Foundation; either version 2 of the License, or (at your > + * option) any later version. > + */ > + > +/dts-v1/; > +/ { > + model = "KVM MPC85xx"; > + compatible = "MPC8544DS", "MPC85xxDS"; > + #address-cells = <1>; > + #size-cells = <1>; > + > + aliases { > + serial0 = &serial0; > + serial1 = &serial1; > + pci0 = &pci0; > + pci1 = &pci1; > + pci2 = &pci2; > + pci3 = &pci3; > + }; > + > + cpus { > + #address-cells = <1>; > + #size-cells = <0>; > + > + PowerPC,85xx@0 { > + device_type = "cpu"; > + reg = <0x0>; > + d-cache-line-size = <32>; // 32 bytes > + i-cache-line-size = <32>; // 32 bytes > + d-cache-size = <0x8000>; // L1, 32K > + i-cache-size = <0x8000>; // L1, 32K > + timebase-frequency = <0>; > + bus-frequency = <0>; > + clock-frequency = <0>; > + next-level-cache = <&L2>; > + }; > + }; > + > + memory { > + device_type = "memory"; > + reg = <0x0 0x0>; // Filled by U-Boot > + }; > + > + soc85xx@e0000000 { > + #address-cells = <1>; > + #size-cells = <1>; > + device_type = "soc"; > + compatible = "simple-bus"; > + > + ranges = <0x0 0xe0000000 0x100000>; > + reg = <0xe0000000 0x1000>; // CCSRBAR 1M > + bus-frequency = <0>; // Filled out by uboot. > + > + memory-controller@2000 { > + compatible = "fsl,8544-memory-controller"; > + reg = <0x2000 0x1000>; > + interrupt-parent = <&mpic>; > + interrupts = <18 2>; > + }; ... You need to remove devices that are not emulated by qemu. The device tree is firmware's way of informing the kernel what devices are present. Since the kernel sees that the memory controller (for example) is present, it is allowed to try to access it... and since qemu doesn't emulate it, that's bad. Same is true for crypto, guts, msi, and all the other devices qemu doesn't emulate. -- Hollis Blanchard IBM Linux Technology Center