From: Kevin Wolf <kwolf@suse.de>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@suse.de>
Subject: [Qemu-devel] [PATCH 3/7] block-vpc: Fix disk size
Date: Mon, 26 Jan 2009 17:59:24 +0100 [thread overview]
Message-ID: <1232989168-27759-4-git-send-email-kwolf@suse.de> (raw)
In-Reply-To: <1232989168-27759-1-git-send-email-kwolf@suse.de>
VirtualPC bases the virtual disk size on the geometry rather than on
the size stored in the header.
Signed-off-by: Kevin Wolf <kwolf@suse.de>
---
block-vpc.c | 9 ++++++---
1 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/block-vpc.c b/block-vpc.c
index 3f25785..3c92bb3 100644
--- a/block-vpc.c
+++ b/block-vpc.c
@@ -150,6 +150,12 @@ static int vpc_open(BlockDriverState *bs, const char *filename, int flags)
if (strncmp(footer->creator, "conectix", 8))
goto fail;
+ // The visible size of a image in Virtual PC depends on the geometry
+ // rather than on the size stored in the footer (the size in the footer
+ // is too large usually)
+ bs->total_sectors = (int64_t)
+ be16_to_cpu(footer->cyls) * footer->heads * footer->secs_per_cyl;
+
lseek(s->fd, be64_to_cpu(footer->data_offset), SEEK_SET);
if (read(fd, buf, HEADER_SIZE) != HEADER_SIZE)
goto fail;
@@ -160,9 +166,6 @@ static int vpc_open(BlockDriverState *bs, const char *filename, int flags)
if (strncmp(dyndisk_header->magic, "cxsparse", 8))
goto fail;
- bs->total_sectors = ((uint64_t)be32_to_cpu(dyndisk_header->max_table_entries) *
- be32_to_cpu(dyndisk_header->block_size)) / 512;
-
lseek(s->fd, be64_to_cpu(dyndisk_header->table_offset), SEEK_SET);
s->max_table_entries = be32_to_cpu(dyndisk_header->max_table_entries);
--
1.6.0.2
next prev parent reply other threads:[~2009-01-26 17:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-26 16:59 [Qemu-devel] [PATCH 0/7] block-vpc: Improve support for VHD images Kevin Wolf
2009-01-26 16:59 ` [Qemu-devel] [PATCH 1/7] block-vpc: Split up struct vpc_subheader Kevin Wolf
2009-01-26 20:27 ` Anthony Liguori
2009-01-26 16:59 ` [Qemu-devel] [PATCH 2/7] block-vpc: Adapt header structures to official documentation Kevin Wolf
2009-01-26 16:59 ` Kevin Wolf [this message]
2009-01-26 16:59 ` [Qemu-devel] [PATCH 4/7] block-vpc: Fix support for images > 4 GB Kevin Wolf
2009-01-27 11:03 ` Kevin Wolf
2009-01-27 14:30 ` Anthony Liguori
2009-01-27 14:29 ` Anthony Liguori
2009-01-26 16:59 ` [Qemu-devel] [PATCH 5/7] block-vpc: Use the qemu block layer Kevin Wolf
2009-01-26 16:59 ` [Qemu-devel] [PATCH 6/7] block-vpc: Write support Kevin Wolf
2009-01-26 16:59 ` [Qemu-devel] [PATCH 7/7] block-vpc: Create images Kevin Wolf
2009-01-26 21:52 ` [Qemu-devel] [PATCH 0/7] block-vpc: Improve support for VHD images Jamie Lokier
2009-01-27 9:20 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1232989168-27759-4-git-send-email-kwolf@suse.de \
--to=kwolf@suse.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).