From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LSYtu-000341-0p
	for qemu-devel@nongnu.org; Thu, 29 Jan 2009 10:33:54 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LSYts-00033J-An
	for qemu-devel@nongnu.org; Thu, 29 Jan 2009 10:33:53 -0500
Received: from [199.232.76.173] (port=60280 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LSYts-00033D-3Z
	for qemu-devel@nongnu.org; Thu, 29 Jan 2009 10:33:52 -0500
Received: from mail27.svc.cra.dublin.eircom.net ([159.134.118.223]:39508)
	by monty-python.gnu.org with smtp (Exim 4.60)
	(envelope-from <markmc@redhat.com>) id 1LSYtr-0002cu-Mr
	for qemu-devel@nongnu.org; Thu, 29 Jan 2009 10:33:51 -0500
From: Mark McLoughlin <markmc@redhat.com>
Date: Thu, 29 Jan 2009 15:33:50 +0000
Message-Id: <1233243230-8280-1-git-send-email-markmc@redhat.com>
Subject: [Qemu-devel] [PATCH] Don't notify virtio devices before S_DRIVER_OK
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Rusty@blaa.localdomain, Mark McLoughlin <markmc@redhat.com>, qemu-devel@nongnu.org, "Russell <rusty"@rustcorp.com.au

Current Linux guests oops if the host notifies of a
config change before a driver has been bound to the
device.

It's pretty pointless for us to do notify of config
changes before status is S_DRIVER_OK anyway, so let's
just not do it.

Signed-off-by: Mark McLoughlin <markmc@redhat.com>
---
 qemu/hw/virtio.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/qemu/hw/virtio.c b/qemu/hw/virtio.c
index 35f4669..78bcc2e 100644
--- a/qemu/hw/virtio.c
+++ b/qemu/hw/virtio.c
@@ -738,6 +738,9 @@ void virtio_notify(VirtIODevice *vdev, VirtQueue *vq)
 
 void virtio_notify_config(VirtIODevice *vdev)
 {
+    if (!(vdev->status & VIRTIO_CONFIG_S_DRIVER_OK))
+        return;
+
     vdev->isr |= 0x03;
     virtio_update_irq(vdev);
 }
-- 
1.6.0.6