From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LUrFV-0000S1-C0
	for qemu-devel@nongnu.org; Wed, 04 Feb 2009 18:33:41 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LUrFS-0000Ra-U4
	for qemu-devel@nongnu.org; Wed, 04 Feb 2009 18:33:40 -0500
Received: from [199.232.76.173] (port=48099 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LUrFS-0000RX-NH
	for qemu-devel@nongnu.org; Wed, 04 Feb 2009 18:33:38 -0500
Received: from g5t0008.atlanta.hp.com ([15.192.0.45]:46224)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <alex.williamson@hp.com>) id 1LUrFN-0004aH-7k
	for qemu-devel@nongnu.org; Wed, 04 Feb 2009 18:33:33 -0500
Subject: Re: [Qemu-devel] Re: [PATCH v2 4/8] qemu:virtio-net: Add a
	virtqueue for control commands from the guest
From: Alex Williamson <alex.williamson@hp.com>
In-Reply-To: <Pine.LNX.4.64.0902050208330.3724@linmac.oyster.ru>
References: <20090203192932.19598.50925.stgit@kvm.aw>
	<20090203192953.19598.41310.stgit@kvm.aw>
	<4988AF7C.50103@codemonkey.ws> <1233788398.7026.1237.camel@lappy>
	<Pine.LNX.4.64.0902050208330.3724@linmac.oyster.ru>
Content-Type: text/plain
Date: Wed, 04 Feb 2009 16:34:06 -0700
Message-Id: <1233790446.7026.1239.camel@lappy>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org, av1474@comtv.ru
Cc: markmc@redhat.com, kvm@vger.kernel.org

On Thu, 2009-02-05 at 02:09 +0300, malc wrote:
> On Wed, 4 Feb 2009, Alex Williamson wrote:
> 
> [..snip..]
> 
> >  
> > +static void virtio_net_handle_ctrl(VirtIODevice *vdev, VirtQueue *vq)
> > +{
> > +    struct virtio_net_ctrl_hdr ctrl;
> > +    virtio_net_ctrl_ack status = VIRTIO_NET_ERR;
> > +    VirtQueueElement elem;
> > +
> > +    while (virtqueue_pop(vq, &elem)) {
> > +        if ((elem.in_num < 1) | (elem.out_num < 1)) {
>                                  ^ intended ?

No, good catch.  Thank you.

-- 
Alex Williamson                             HP Open Source & Linux Org.