From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LV26O-0002d2-4C for qemu-devel@nongnu.org; Thu, 05 Feb 2009 06:09:00 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LV26K-0002bF-N1 for qemu-devel@nongnu.org; Thu, 05 Feb 2009 06:08:57 -0500 Received: from [199.232.76.173] (port=51257 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LV26K-0002bC-HG for qemu-devel@nongnu.org; Thu, 05 Feb 2009 06:08:56 -0500 Received: from mx2.redhat.com ([66.187.237.31]:39289) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LV26K-0000em-1d for qemu-devel@nongnu.org; Thu, 05 Feb 2009 06:08:56 -0500 From: Avi Kivity Date: Thu, 5 Feb 2009 13:08:43 +0200 Message-Id: <1233832126-9046-4-git-send-email-avi@redhat.com> In-Reply-To: <1233832126-9046-1-git-send-email-avi@redhat.com> References: <1233832126-9046-1-git-send-email-avi@redhat.com> Subject: [Qemu-devel] [PATCH 3/6] audio: remove error handling from qemu_malloc() callers Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori , qemu-devel@nongnu.org Signed-off-by: Avi Kivity --- audio/audio.c | 23 ++++++++--------------- audio/wavcapture.c | 5 ----- 2 files changed, 8 insertions(+), 20 deletions(-) diff --git a/audio/audio.c b/audio/audio.c index e2635c0..b0a5f3b 100644 --- a/audio/audio.c +++ b/audio/audio.c @@ -197,8 +197,8 @@ void *audio_calloc (const char *funcname, int nmemb, size_t size) static char *audio_alloc_prefix (const char *s) { const char qemu_prefix[] = "QEMU_"; - size_t len; - char *r; + size_t len, i; + char *r, *u; if (!s) { return NULL; @@ -207,17 +207,15 @@ static char *audio_alloc_prefix (const char *s) len = strlen (s); r = qemu_malloc (len + sizeof (qemu_prefix)); - if (r) { - size_t i; - char *u = r + sizeof (qemu_prefix) - 1; + u = r + sizeof (qemu_prefix) - 1; - pstrcpy (r, len + sizeof (qemu_prefix), qemu_prefix); - pstrcat (r, len + sizeof (qemu_prefix), s); + pstrcpy (r, len + sizeof (qemu_prefix), qemu_prefix); + pstrcat (r, len + sizeof (qemu_prefix), s); - for (i = 0; i < len; ++i) { - u[i] = qemu_toupper(u[i]); - } + for (i = 0; i < len; ++i) { + u[i] = qemu_toupper(u[i]); } + return r; } @@ -460,11 +458,6 @@ static void audio_process_options (const char *prefix, * sizeof) */ optlen = len + preflen + sizeof (qemu_prefix) + 1; optname = qemu_malloc (optlen); - if (!optname) { - dolog ("Could not allocate memory for option name `%s'\n", - opt->name); - continue; - } pstrcpy (optname, optlen, qemu_prefix); diff --git a/audio/wavcapture.c b/audio/wavcapture.c index 9919171..6d1c441 100644 --- a/audio/wavcapture.c +++ b/audio/wavcapture.c @@ -120,11 +120,6 @@ int wav_start_capture (CaptureState *s, const char *path, int freq, ops.destroy = wav_destroy; wav = qemu_mallocz (sizeof (*wav)); - if (!wav) { - term_printf ("Could not allocate memory for wav capture (%zu bytes)", - sizeof (*wav)); - return -1; - } shift = bits16 + stereo; hdr[34] = bits16 ? 0x10 : 0x08; -- 1.6.1.1