From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LVV50-0001SS-5W for qemu-devel@nongnu.org; Fri, 06 Feb 2009 13:05:30 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LVV4x-0001P9-Aa for qemu-devel@nongnu.org; Fri, 06 Feb 2009 13:05:29 -0500 Received: from [199.232.76.173] (port=51115 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LVV4x-0001Oz-3m for qemu-devel@nongnu.org; Fri, 06 Feb 2009 13:05:27 -0500 Received: from g1t0027.austin.hp.com ([15.216.28.34]:23856) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LVV4w-0006jY-M9 for qemu-devel@nongnu.org; Fri, 06 Feb 2009 13:05:26 -0500 From: Alex Williamson In-Reply-To: <498C4258.3060502@codemonkey.ws> References: <20090206044853.3116.46699.stgit@kvm.aw> <498C4258.3060502@codemonkey.ws> Content-Type: text/plain Date: Fri, 06 Feb 2009 11:06:03 -0700 Message-Id: <1233943563.7026.1345.camel@lappy> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH][RFC] qemu:virtio-net: Use TUNSETTXFILTER for MAC filtering Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org On Fri, 2009-02-06 at 07:59 -0600, Anthony Liguori wrote: > > Instead of having each network device do it's own filtering if the VLAN > doesn't support it, I think we should move the software filtering to the > VLAN layer so that we aren't duplicating code in each network device. > > Also, instead of using IFF_xxx, I think we should introduce our own > flags. net/if.h doesn't exist on Windows most likely. Thanks for the comments, I'll look into making these changes. Alex