From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LVV8X-0006DB-Sy for qemu-devel@nongnu.org; Fri, 06 Feb 2009 13:09:09 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LVV8W-0006AU-5q for qemu-devel@nongnu.org; Fri, 06 Feb 2009 13:09:09 -0500 Received: from [199.232.76.173] (port=51300 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LVV8V-0006A7-Ue for qemu-devel@nongnu.org; Fri, 06 Feb 2009 13:09:08 -0500 Received: from g5t0006.atlanta.hp.com ([15.192.0.43]:8509) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LVV8V-0007Ga-KY for qemu-devel@nongnu.org; Fri, 06 Feb 2009 13:09:07 -0500 From: Alex Williamson In-Reply-To: <1233906439.3673.20.camel@blaa> References: <20090206044853.3116.46699.stgit@kvm.aw> <1233906439.3673.20.camel@blaa> Content-Type: text/plain Date: Fri, 06 Feb 2009 11:09:45 -0700 Message-Id: <1233943785.7026.1353.camel@lappy> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH][RFC] qemu:virtio-net: Use TUNSETTXFILTER for MAC filtering Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Mark McLoughlin Cc: qemu-devel@nongnu.org On Fri, 2009-02-06 at 07:47 +0000, Mark McLoughlin wrote: > On Thu, 2009-02-05 at 21:51 -0700, Alex Williamson wrote: > > Here are a couple issues I'm still pondering: > > - Is the fd_rx_filter() interface sufficiently generic > > - Should vlan_set_hw_rx_filter() live in net.c or elsewhere > > - Is it ok to call fd_rx_filter() against all the vlan clients. I > > exit on the first one, which covers the simple config. > > All of these are related to the problem that we're trying to add > optimizations for the simple config (i.e. one NIC associated with one > tap interface) without any clean representation of the simple config in > the API. > > It's not strictly needed in this case - the VLAN API for setting filters > could aggregate the filters of all VLAN clients - but what you really > want is to only have the filter apply if virtio-net is paired with a tap > interface. Yes, or more precisely, it should only be applied if there are exactly two devices on the vlan, and the "other" device implements fd_rx_filter. I'll enforce that in the code. Thanks, Alex