From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LVXwy-0001of-4R for qemu-devel@nongnu.org; Fri, 06 Feb 2009 16:09:24 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LVXws-0001iB-CF for qemu-devel@nongnu.org; Fri, 06 Feb 2009 16:09:20 -0500 Received: from [199.232.76.173] (port=51591 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LVXwr-0001h7-S7 for qemu-devel@nongnu.org; Fri, 06 Feb 2009 16:09:17 -0500 Received: from mx2.redhat.com ([66.187.237.31]:54577) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LVXwq-0007ny-NR for qemu-devel@nongnu.org; Fri, 06 Feb 2009 16:09:17 -0500 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n16L9Er3001160 for ; Fri, 6 Feb 2009 16:09:14 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n16L9DFg029479 for ; Fri, 6 Feb 2009 16:09:14 -0500 Received: from blackpad.localdomain (vpn-10-11.bos.redhat.com [10.16.10.11]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n16L9DDF014586 for ; Fri, 6 Feb 2009 16:09:13 -0500 From: Eduardo Habkost Date: Fri, 6 Feb 2009 19:08:52 -0200 Message-Id: <1233954540-4754-2-git-send-email-ehabkost@redhat.com> In-Reply-To: <1233954540-4754-1-git-send-email-ehabkost@redhat.com> References: <1233954540-4754-1-git-send-email-ehabkost@redhat.com> Subject: [Qemu-devel] [PATCH 1/9] vnc: abort on unknown options Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Currently, if the user specifies an authentication mode that is not compiled in, qemu silently falls back to disabling authentication. Aborting instead of falling back to an unsafe mode is the right thing to do. Signed-off-by: Eduardo Habkost --- vnc.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/vnc.c b/vnc.c index 68df599..5c2368c 100644 --- a/vnc.c +++ b/vnc.c @@ -2441,6 +2441,9 @@ int vnc_display_open(DisplayState *ds, const char *display) return -1; } #endif + } else { + fprintf(stderr, "Invalid vnc option: %s\n", options); + return -1; } } -- 1.6.0.2.GIT