From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LXGjI-0000Z9-3J for qemu-devel@nongnu.org; Wed, 11 Feb 2009 10:10:24 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LXGjG-0000YL-Fb for qemu-devel@nongnu.org; Wed, 11 Feb 2009 10:10:23 -0500 Received: from [199.232.76.173] (port=48516 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LXGjG-0000YG-CL for qemu-devel@nongnu.org; Wed, 11 Feb 2009 10:10:22 -0500 Received: from g4t0014.houston.hp.com ([15.201.24.17]:14414) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LXGjG-0000x4-3R for qemu-devel@nongnu.org; Wed, 11 Feb 2009 10:10:22 -0500 From: Alex Williamson In-Reply-To: <20090210212902.9760.6747.stgit@kvm.aw> References: <20090210212841.9760.96780.stgit@kvm.aw> <20090210212902.9760.6747.stgit@kvm.aw> Content-Type: text/plain Date: Wed, 11 Feb 2009 08:11:01 -0700 Message-Id: <1234365061.7026.1511.camel@lappy> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 4/4] qemu:e1000: Add support for qemu_vlan_rxfilter Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kvm@vger.kernel.org On Tue, 2009-02-10 at 14:29 -0700, Alex Williamson wrote: > Make use of qemu_vlan_rxfilter so that we can filter at a lower > level. We implement callbacks for devices being added and removed > so that we can fall back to our own filtering or make another attempt > to push filtering off to someone else. Hmm, I've thought of a bug in this patch, I'm not accounting for the multicast hash e1000 can use for imperfect filtering. I'll need to rework this one, maybe skip the tap filter if the hash is in use. This is independent of the other patches though. Thanks, Alex