From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LXKnu-0006mA-E6 for qemu-devel@nongnu.org; Wed, 11 Feb 2009 14:31:26 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LXKns-0006ly-Tk for qemu-devel@nongnu.org; Wed, 11 Feb 2009 14:31:25 -0500 Received: from [199.232.76.173] (port=55257 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LXKns-0006lv-Om for qemu-devel@nongnu.org; Wed, 11 Feb 2009 14:31:24 -0500 Received: from mx2.redhat.com ([66.187.237.31]:44052) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LXKns-0002Wq-Cb for qemu-devel@nongnu.org; Wed, 11 Feb 2009 14:31:24 -0500 From: Mark McLoughlin In-Reply-To: <20090210212841.9760.96780.stgit@kvm.aw> References: <20090210212841.9760.96780.stgit@kvm.aw> Content-Type: text/plain Date: Wed, 11 Feb 2009 19:31:18 +0000 Message-Id: <1234380678.14052.238.camel@blaa> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 0/4] qemu: TAP filtering support Reply-To: Mark McLoughlin , qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alex Williamson Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org Hi Alex, Just had a quick looked over these and they seem pretty good, but some broad comments: - The logic around "is this a NIC+TAP pair?" would be good to have a better API around. We need this to merge virtio GSO support too. Anthony had some ideas here. - I think you could keep the client_added()/removed() logic in net.c and things would be a lot cleaner. I think you just want to trigger a reload of the filter, right? So a "reload this filter" callback to qemu_vlan_rxfilter() might do it. - What do we need rxfilter=on|off on the command line for? Cheers, Mark.