From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LXeYd-0003SI-3Q for qemu-devel@nongnu.org; Thu, 12 Feb 2009 11:36:59 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LXeYb-0003QZ-6G for qemu-devel@nongnu.org; Thu, 12 Feb 2009 11:36:58 -0500 Received: from [199.232.76.173] (port=42700 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LXeYa-0003QF-2l for qemu-devel@nongnu.org; Thu, 12 Feb 2009 11:36:56 -0500 Received: from g1t0028.austin.hp.com ([15.216.28.35]:3044) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LXeYY-0002us-VP for qemu-devel@nongnu.org; Thu, 12 Feb 2009 11:36:55 -0500 Subject: Re: [Qemu-devel] [PATCH 3/4] qemu:virtio-net: Add support for qemu_vlan_rxfilter From: Alex Williamson In-Reply-To: <200902121626.58977.paul@codesourcery.com> References: <20090210212841.9760.96780.stgit@kvm.aw> <20090210212857.9760.31288.stgit@kvm.aw> <200902121626.58977.paul@codesourcery.com> Content-Type: text/plain Date: Thu, 12 Feb 2009 09:36:47 -0700 Message-Id: <1234456607.25178.177.camel@bling> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paul Brook Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org On Thu, 2009-02-12 at 16:26 +0000, Paul Brook wrote: > > +static void virtio_net_vlan_client_added(void *opaque) > >... > > +static void virtio_net_vlan_client_removed(void *opaque) > > Why are these two different? > > It looks like what you really want is a callback for "Something changed, > and you need to reset your MAC filter." I think we'd end up with a race if we only had one callback. For instance if "change" was the result of a vlan client being removed, the tap would clear the filter and the nic would try to install a filter. The results would be different based on the calling order. Alex