* [Qemu-devel] [PATCH] include qemu-kvm.h at all cases.
@ 2009-02-12 20:36 Glauber Costa
2009-02-17 0:01 ` [Qemu-devel] " Dustin Kirkland
2009-02-17 18:00 ` Avi Kivity
0 siblings, 2 replies; 3+ messages in thread
From: Glauber Costa @ 2009-02-12 20:36 UTC (permalink / raw)
To: kvm; +Cc: qemu-devel, avi
We don't have any kind of kvm support for linux-user targets,
but conditionalizing the inclusion of kvm header make
linux-user compilation break. And we don't have a reason to
prevent that, do we?
Signed-off-by: Glauber Costa <glommer@redhat.com>
---
qemu/gdbstub.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/qemu/gdbstub.c b/qemu/gdbstub.c
index c4d4361..a23e916 100644
--- a/qemu/gdbstub.c
+++ b/qemu/gdbstub.c
@@ -33,8 +33,8 @@
#include "qemu-char.h"
#include "sysemu.h"
#include "gdbstub.h"
-#include "qemu-kvm.h"
#endif
+#include "qemu-kvm.h"
#define MAX_PACKET_LENGTH 4096
--
1.5.6.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Qemu-devel] Re: [PATCH] include qemu-kvm.h at all cases.
2009-02-12 20:36 [Qemu-devel] [PATCH] include qemu-kvm.h at all cases Glauber Costa
@ 2009-02-17 0:01 ` Dustin Kirkland
2009-02-17 18:00 ` Avi Kivity
1 sibling, 0 replies; 3+ messages in thread
From: Dustin Kirkland @ 2009-02-17 0:01 UTC (permalink / raw)
To: Glauber Costa; +Cc: qemu-devel, kvm, avi
On 2/12/09, Glauber Costa <glommer@redhat.com> wrote:
> We don't have any kind of kvm support for linux-user targets,
> but conditionalizing the inclusion of kvm header make
> linux-user compilation break. And we don't have a reason to
> prevent that, do we?
Ack, again, same problem here. The lack of inclusion of this header
breaks the build of kvm-84 for the Ubuntu package.
:-Dustin
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Qemu-devel] Re: [PATCH] include qemu-kvm.h at all cases.
2009-02-12 20:36 [Qemu-devel] [PATCH] include qemu-kvm.h at all cases Glauber Costa
2009-02-17 0:01 ` [Qemu-devel] " Dustin Kirkland
@ 2009-02-17 18:00 ` Avi Kivity
1 sibling, 0 replies; 3+ messages in thread
From: Avi Kivity @ 2009-02-17 18:00 UTC (permalink / raw)
To: Glauber Costa; +Cc: qemu-devel, kvm
Glauber Costa wrote:
> We don't have any kind of kvm support for linux-user targets,
> but conditionalizing the inclusion of kvm header make
> linux-user compilation break. And we don't have a reason to
> prevent that, do we?
>
Applied, thanks.
--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-02-17 17:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-02-12 20:36 [Qemu-devel] [PATCH] include qemu-kvm.h at all cases Glauber Costa
2009-02-17 0:01 ` [Qemu-devel] " Dustin Kirkland
2009-02-17 18:00 ` Avi Kivity
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).