From: Uri Lublin <uril@redhat.com>
To: qemu-devel@nongnu.org
Cc: Uri Lublin <uril@redhat.com>
Subject: [Qemu-devel] [PATCH 0/2] Introducing qcow2 extensions + keep backing file format (v4)
Date: Wed, 18 Feb 2009 19:51:39 +0200 [thread overview]
Message-ID: <1234979501-9454-1-git-send-email-uril@redhat.com> (raw)
This patch set is an implementation of keeping a backing file format, such
that we would not need probing to figure it out.
I introduce qcow2 extensions which can be used in the future.
I use one such an extension to keep the backing file format,
and use it when opening a file.
Qcow2 extensions are built of magic (id) len (in bytes) and data (len bytes).
They reside between the end of the header and the filename.
We keep the backing file format in a such a qcow2 extension, to
1. Provide a way to know the backing file format without probing
it (setting the format at creation time).
2. Enable using qcow2 format over host block devices.
(only if the user specifically asks for it, by providing the format
at image creation time).
This patchset is backward compatible in two ways:
1. It does not break old images (no extensions -> probe).
2. New images can be opened by old Qemu (extensions skipped -> probe).
I've added bdrv_create2 and drv->bdrv_create2 (implemented only
by block-qcow2 currently) to pass the backing-format to create.
Based on a work done by Shahar Frank.
Also fixes a security flaw found by Daniel P. Berrange on [1]
which summarizes: "Autoprobing: just say no."
[1] http://lists.gnu.org/archive/html/qemu-devel/2008-12/msg01083.html
First patch implements qcow2 extensions + bdrv_create2
Second patch modifies qemu-img such that the user can use it.
Currently this is implemented only for qcow2.
Changes from v3:
Rebased to current HEAD.
Removed some unneeded comments.
Thanks,
Uri.
next reply other threads:[~2009-02-18 17:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-18 17:51 Uri Lublin [this message]
2009-02-18 17:51 ` [Qemu-devel] [PATCH 1/2] Introducing qcow2 extensions + keep backing file format (v4) Uri Lublin
2009-02-18 17:51 ` [Qemu-devel] [PATCH 2/2] qemu-img: adding a "-F base_fmt" option to "qemu-img create -b" (v4) Uri Lublin
2009-02-26 18:48 ` [Qemu-devel] [PATCH 1/2] Introducing qcow2 extensions + keep backing file format (v4) Anthony Liguori
2009-03-01 11:22 ` Uri Lublin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1234979501-9454-1-git-send-email-uril@redhat.com \
--to=uril@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).