qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eduardo Habkost <ehabkost@redhat.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH 3/4] Move SECTOR_BITS/SECTOR_SIZE to block.h
Date: Thu, 19 Feb 2009 18:19:35 -0300	[thread overview]
Message-ID: <1235078376-25559-4-git-send-email-ehabkost@redhat.com> (raw)
In-Reply-To: <1235078376-25559-1-git-send-email-ehabkost@redhat.com>

We will use those defines on other parts of the Qemu code.

Remove redundant SECTOR_SIZE define from block-vmdk.c, also.

Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
 block-vmdk.c |    1 -
 block.c      |    3 ---
 block.h      |    3 +++
 3 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/block-vmdk.c b/block-vmdk.c
index 416fb95..7ac79b3 100644
--- a/block-vmdk.c
+++ b/block-vmdk.c
@@ -110,7 +110,6 @@ static int vmdk_probe(const uint8_t *buf, int buf_size, const char *filename)
 
 #define CHECK_CID 1
 
-#define SECTOR_SIZE 512
 #define DESC_SIZE 20*SECTOR_SIZE	// 20 sectors of 512 bytes each
 #define HEADER_SIZE 512   			// first sector of 512 bytes
 
diff --git a/block.c b/block.c
index 4f4bf7c..ba7fcf6 100644
--- a/block.c
+++ b/block.c
@@ -38,9 +38,6 @@
 #include <sys/disk.h>
 #endif
 
-#define SECTOR_BITS 9
-#define SECTOR_SIZE (1 << SECTOR_BITS)
-
 typedef struct BlockDriverAIOCBSync {
     BlockDriverAIOCB common;
     QEMUBH *bh;
diff --git a/block.h b/block.h
index e1927dd..ee0d403 100644
--- a/block.h
+++ b/block.h
@@ -4,6 +4,9 @@
 #include "qemu-aio.h"
 #include "qemu-common.h"
 
+#define SECTOR_BITS 9
+#define SECTOR_SIZE (1 << SECTOR_BITS)
+
 /* block.c */
 typedef struct BlockDriver BlockDriver;
 
-- 
1.6.1

  parent reply	other threads:[~2009-02-19 21:20 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-19 21:19 [Qemu-devel] [PATCH 0/4] CVE-2008-0928 security fix Eduardo Habkost
2009-02-19 21:19 ` [Qemu-devel] [PATCH 1/4] vmdk: check for negative sector nums also Eduardo Habkost
2009-02-19 21:44   ` Stefan Weil
2009-02-19 21:56     ` Eduardo Habkost
2009-02-19 21:19 ` [Qemu-devel] [PATCH 2/4] hw/sd.c: remove ununsed SECTOR_SIZE define Eduardo Habkost
2009-02-19 21:19 ` Eduardo Habkost [this message]
2009-02-19 21:19 ` [Qemu-devel] [PATCH 4/4] Fix CVE-2008-0928 - insufficient block device address range checking Eduardo Habkost
2009-02-19 21:40   ` Eduardo Habkost
2009-02-19 22:21   ` Aurelien Jarno

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1235078376-25559-4-git-send-email-ehabkost@redhat.com \
    --to=ehabkost@redhat.com \
    --cc=anthony@codemonkey.ws \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).