From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Lg1tM-0003Yw-W9 for qemu-devel@nongnu.org; Sat, 07 Mar 2009 14:09:01 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Lg1tL-0003XC-JL for qemu-devel@nongnu.org; Sat, 07 Mar 2009 14:08:59 -0500 Received: from [199.232.76.173] (port=57960 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Lg1tK-0003Wn-BD for qemu-devel@nongnu.org; Sat, 07 Mar 2009 14:08:58 -0500 Received: from ns.suse.de ([195.135.220.2]:37591 helo=mx1.suse.de) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Lg1tJ-0002nr-Nq for qemu-devel@nongnu.org; Sat, 07 Mar 2009 14:08:58 -0500 From: Alexander Graf Date: Sat, 7 Mar 2009 20:08:49 +0100 Message-Id: <1236452932-31622-9-git-send-email-agraf@suse.de> In-Reply-To: <1236452932-31622-8-git-send-email-agraf@suse.de> References: <1236452932-31622-1-git-send-email-agraf@suse.de> <1236452932-31622-2-git-send-email-agraf@suse.de> <1236452932-31622-3-git-send-email-agraf@suse.de> <1236452932-31622-4-git-send-email-agraf@suse.de> <1236452932-31622-5-git-send-email-agraf@suse.de> <1236452932-31622-6-git-send-email-agraf@suse.de> <1236452932-31622-7-git-send-email-agraf@suse.de> <1236452932-31622-8-git-send-email-agraf@suse.de> Subject: [Qemu-devel] [PATCH 08/11] PPC64: Fix RFI(d) Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: blauwirbel@gmail.com, Alexander Graf The current implementation masks some MSR bits from SRR1 as it is given on rfi(d). This looks pretty wrong and breaks Altivec. Signed-off-by: Alexander Graf --- target-ppc/op_helper.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/target-ppc/op_helper.c b/target-ppc/op_helper.c index 76fe8f6..f21f695 100644 --- a/target-ppc/op_helper.c +++ b/target-ppc/op_helper.c @@ -1671,20 +1671,20 @@ static always_inline void do_rfi (target_ulong nip, target_ulong msr, void helper_rfi (void) { do_rfi(env->spr[SPR_SRR0], env->spr[SPR_SRR1], - ~((target_ulong)0xFFFF0000), 1); + ~((target_ulong)0x0), 1); } #if defined(TARGET_PPC64) void helper_rfid (void) { do_rfi(env->spr[SPR_SRR0], env->spr[SPR_SRR1], - ~((target_ulong)0xFFFF0000), 0); + ~((target_ulong)0x0), 0); } void helper_hrfid (void) { do_rfi(env->spr[SPR_HSRR0], env->spr[SPR_HSRR1], - ~((target_ulong)0xFFFF0000), 0); + ~((target_ulong)0x0), 0); } #endif #endif -- 1.6.0.2