qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Tristan Gingold <gingold@adacore.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH 04/25] Fix bug: integer conditionnal branch offset is 21 bits wide.
Date: Tue, 24 Mar 2009 16:47:46 +0100	[thread overview]
Message-ID: <1237909687-31711-5-git-send-email-gingold@adacore.com> (raw)
In-Reply-To: <1237909687-31711-4-git-send-email-gingold@adacore.com>

Signed-off-by: Tristan Gingold <gingold@adacore.com>
---
 target-alpha/translate.c |   20 ++++++++++----------
 1 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/target-alpha/translate.c b/target-alpha/translate.c
index 09065ac..dff3f1d 100644
--- a/target-alpha/translate.c
+++ b/target-alpha/translate.c
@@ -290,7 +290,7 @@ static always_inline void gen_store_mem (DisasContext *ctx,
 
 static always_inline void gen_bcond (DisasContext *ctx,
                                      TCGCond cond,
-                                     int ra, int32_t disp16, int mask)
+                                     int ra, int32_t disp, int mask)
 {
     int l1, l2;
 
@@ -313,7 +313,7 @@ static always_inline void gen_bcond (DisasContext *ctx,
     tcg_gen_movi_i64(cpu_pc, ctx->pc);
     tcg_gen_br(l2);
     gen_set_label(l1);
-    tcg_gen_movi_i64(cpu_pc, ctx->pc + (int64_t)(disp16 << 2));
+    tcg_gen_movi_i64(cpu_pc, ctx->pc + (int64_t)(disp << 2));
     gen_set_label(l2);
 }
 
@@ -2285,42 +2285,42 @@ static always_inline int translate_one (DisasContext *ctx, uint32_t insn)
         break;
     case 0x38:
         /* BLBC */
-        gen_bcond(ctx, TCG_COND_EQ, ra, disp16, 1);
+        gen_bcond(ctx, TCG_COND_EQ, ra, disp21, 1);
         ret = 1;
         break;
     case 0x39:
         /* BEQ */
-        gen_bcond(ctx, TCG_COND_EQ, ra, disp16, 0);
+        gen_bcond(ctx, TCG_COND_EQ, ra, disp21, 0);
         ret = 1;
         break;
     case 0x3A:
         /* BLT */
-        gen_bcond(ctx, TCG_COND_LT, ra, disp16, 0);
+        gen_bcond(ctx, TCG_COND_LT, ra, disp21, 0);
         ret = 1;
         break;
     case 0x3B:
         /* BLE */
-        gen_bcond(ctx, TCG_COND_LE, ra, disp16, 0);
+        gen_bcond(ctx, TCG_COND_LE, ra, disp21, 0);
         ret = 1;
         break;
     case 0x3C:
         /* BLBS */
-        gen_bcond(ctx, TCG_COND_NE, ra, disp16, 1);
+        gen_bcond(ctx, TCG_COND_NE, ra, disp21, 1);
         ret = 1;
         break;
     case 0x3D:
         /* BNE */
-        gen_bcond(ctx, TCG_COND_NE, ra, disp16, 0);
+        gen_bcond(ctx, TCG_COND_NE, ra, disp21, 0);
         ret = 1;
         break;
     case 0x3E:
         /* BGE */
-        gen_bcond(ctx, TCG_COND_GE, ra, disp16, 0);
+        gen_bcond(ctx, TCG_COND_GE, ra, disp21, 0);
         ret = 1;
         break;
     case 0x3F:
         /* BGT */
-        gen_bcond(ctx, TCG_COND_GT, ra, disp16, 0);
+        gen_bcond(ctx, TCG_COND_GT, ra, disp21, 0);
         ret = 1;
         break;
     invalid_opc:
-- 
1.6.2

  reply	other threads:[~2009-03-24 15:48 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-24 15:47 [Qemu-devel] [PATCH 0/25]: add alpha es40 system emulation (v3) Tristan Gingold
2009-03-24 15:47 ` [Qemu-devel] [PATCH 01/25] Add support for multi-level phys map Tristan Gingold
2009-03-24 15:47   ` [Qemu-devel] [PATCH 02/25] Fix bug: palcode is at least 6 bits Tristan Gingold
2009-03-24 15:47     ` [Qemu-devel] [PATCH 03/25] Fix bug: do not mask address LSBs for ldwu Tristan Gingold
2009-03-24 15:47       ` Tristan Gingold [this message]
2009-03-24 15:47         ` [Qemu-devel] [PATCH 05/25] bug fix: avoid nop to override next instruction Tristan Gingold
2009-03-24 15:47           ` [Qemu-devel] [PATCH 06/25] Fix temp free for hw_st Tristan Gingold
2009-03-24 15:47             ` [Qemu-devel] [PATCH 07/25] Increase Alpha physical address size to 44 bits Tristan Gingold
2009-03-24 15:47               ` [Qemu-devel] [PATCH 08/25] Alpha: set target page size to 13 bits Tristan Gingold
2009-03-24 15:47                 ` [Qemu-devel] [PATCH 09/25] Allow 5 mmu indexes Tristan Gingold
2009-03-24 15:47                   ` [Qemu-devel] [PATCH 10/25] Split cpu_mmu_index into cpu_mmu_index_data and cpu_mmu_index_code Tristan Gingold
2009-03-24 15:47                     ` [Qemu-devel] [PATCH 11/25] Add square wave output support Tristan Gingold
2009-03-24 15:47                       ` [Qemu-devel] [PATCH 12/25] Add ali1543 super IO pci device Tristan Gingold
2009-03-24 15:47                         ` [Qemu-devel] [PATCH 13/25] Add 21272 chipset (memory and pci controller for alpha) Tristan Gingold
2009-03-24 15:47                           ` [Qemu-devel] [PATCH 14/25] Add target-alpha/machine.c and hw/es40.c for es40 machine emulation Tristan Gingold
2009-03-24 15:47                             ` [Qemu-devel] [PATCH 15/25] Move softmmu_helper.h from exec.h to op_helper.c on alpha Tristan Gingold
2009-03-24 15:47                               ` [Qemu-devel] [PATCH 16/25] Document which IPR are used by 21264 Tristan Gingold
2009-03-24 15:47                                 ` [Qemu-devel] [PATCH 17/25] tb_flush helper should flush the tb (and not the tlb) Tristan Gingold
2009-03-24 15:48                                   ` [Qemu-devel] [PATCH 18/25] Add instruction name in comments for hw_ld opcode Tristan Gingold
2009-03-24 15:48                                     ` [Qemu-devel] [PATCH 19/25] Remove PALCODE_ declarations (unused) Tristan Gingold
2009-03-24 15:48                                       ` [Qemu-devel] [PATCH 20/25] alpha ld helpers now directly return the value Tristan Gingold
2009-03-24 15:48                                         ` [Qemu-devel] [PATCH 21/25] Add alpha_cpu_list Tristan Gingold
2009-03-24 15:48                                           ` [Qemu-devel] [PATCH 22/25] Alpha: lower parent irq when irq is lowered Tristan Gingold
2009-03-24 15:48                                             ` [Qemu-devel] [PATCH 23/25] Move linux-user pal emulation to linux-user/ Tristan Gingold
2009-03-24 15:48                                               ` [Qemu-devel] [PATCH 24/25] Correctly decode hw_ld/hw_st opcodes for all alpha implementations Tristan Gingold
2009-03-24 15:48                                                 ` [Qemu-devel] [PATCH 25/25] Add full emulation for 21264 Tristan Gingold
2009-03-24 23:00                           ` [Qemu-devel] [PATCH 13/25] Add 21272 chipset (memory and pci controller for alpha) Robert Reif
2009-03-25  7:58                             ` Tristan Gingold
2009-03-25  8:09                             ` Tristan Gingold
2009-03-29  0:37                   ` [Qemu-devel] [PATCH 09/25] Allow 5 mmu indexes Aurelien Jarno
2009-03-24 16:46   ` [Qemu-devel] [PATCH 01/25] Add support for multi-level phys map Paul Brook
2009-03-24 19:42 ` [Qemu-devel] [PATCH 0/25]: add alpha es40 system emulation (v3) Brian Wheeler
2009-03-25  7:37   ` Tristan Gingold
2009-03-25 12:43     ` Brian Wheeler
2009-03-25 12:53       ` Tristan Gingold
2009-03-29  0:14 ` Aurelien Jarno
2009-03-29  0:31   ` Aurelien Jarno

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1237909687-31711-5-git-send-email-gingold@adacore.com \
    --to=gingold@adacore.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).