qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Glauber Costa <glommer@redhat.com>
To: qemu-devel@nongnu.org
Cc: markmc@redhat.com, aliguori@us.ibm.com
Subject: [Qemu-devel] [PATCH] Remove -s flag in Makefile
Date: Wed, 25 Mar 2009 15:45:14 -0300	[thread overview]
Message-ID: <1238006714-27209-1-git-send-email-glommer@redhat.com> (raw)

install -s is pretty and cute, but makes the binary get into the build
directory without any debug information. This is bad, and makes glommer
sad. Also, tools that attempt to extract that data, like fedora debuginfo
extractor, will fail.

Signed-off-by: Glauber Costa <glommer@redhat.com>
---
 Makefile |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/Makefile b/Makefile
index 82fec80..859614b 100644
--- a/Makefile
+++ b/Makefile
@@ -251,7 +251,7 @@ endif
 install: all $(if $(BUILD_DOCS),install-doc)
 	mkdir -p "$(DESTDIR)$(bindir)"
 ifneq ($(TOOLS),)
-	$(INSTALL) -m 755 -s $(TOOLS) "$(DESTDIR)$(bindir)"
+	$(INSTALL) -m 755 $(TOOLS) "$(DESTDIR)$(bindir)"
 endif
 ifneq ($(BLOBS),)
 	mkdir -p "$(DESTDIR)$(datadir)"
-- 
1.6.0.6

             reply	other threads:[~2009-03-25 18:41 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-25 18:45 Glauber Costa [this message]
2009-03-25 19:49 ` [Qemu-devel] [PATCH] Remove -s flag in Makefile Riku Voipio
2009-03-25 19:56   ` Anthony Liguori
2009-03-26 18:34     ` Lennart Sorensen
2009-03-26 18:50     ` Avi Kivity
2009-03-26 19:02       ` M. Warner Losh
2009-03-26 19:08         ` Lennart Sorensen
2009-03-26 19:20           ` Michael Jennings
2009-03-26 19:30           ` M. Warner Losh
2009-03-26 19:48             ` Lennart Sorensen
2009-03-26 20:07               ` M. Warner Losh
2009-03-26 21:47                 ` Lennart Sorensen
2009-03-26 21:09             ` Riku Voipio
2009-03-26 21:16               ` M. Warner Losh
2009-03-26 22:11                 ` Riku Voipio
2009-03-26 23:11                   ` M. Warner Losh
2009-03-26 21:42             ` Gerd Hoffmann
2009-03-26 21:45               ` Robert Riebisch
2009-03-26 19:19       ` Riku Voipio
2009-03-25 20:08 ` Johannes Schindelin
2009-03-25 20:26   ` M. Warner Losh
2009-03-25 20:45     ` Anthony Liguori
2009-04-03  9:27       ` Jan Marten Simons

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1238006714-27209-1-git-send-email-glommer@redhat.com \
    --to=glommer@redhat.com \
    --cc=aliguori@us.ibm.com \
    --cc=markmc@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).