From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LmY2A-0005nP-Bj for qemu-devel@nongnu.org; Wed, 25 Mar 2009 14:41:02 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LmY24-0005kU-BU for qemu-devel@nongnu.org; Wed, 25 Mar 2009 14:41:00 -0400 Received: from [199.232.76.173] (port=42336 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LmY24-0005kN-1X for qemu-devel@nongnu.org; Wed, 25 Mar 2009 14:40:56 -0400 Received: from mx2.redhat.com ([66.187.237.31]:53877) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LmY23-000822-Gn for qemu-devel@nongnu.org; Wed, 25 Mar 2009 14:40:55 -0400 From: Glauber Costa Date: Wed, 25 Mar 2009 15:45:14 -0300 Message-Id: <1238006714-27209-1-git-send-email-glommer@redhat.com> Subject: [Qemu-devel] [PATCH] Remove -s flag in Makefile Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: markmc@redhat.com, aliguori@us.ibm.com install -s is pretty and cute, but makes the binary get into the build directory without any debug information. This is bad, and makes glommer sad. Also, tools that attempt to extract that data, like fedora debuginfo extractor, will fail. Signed-off-by: Glauber Costa --- Makefile | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Makefile b/Makefile index 82fec80..859614b 100644 --- a/Makefile +++ b/Makefile @@ -251,7 +251,7 @@ endif install: all $(if $(BUILD_DOCS),install-doc) mkdir -p "$(DESTDIR)$(bindir)" ifneq ($(TOOLS),) - $(INSTALL) -m 755 -s $(TOOLS) "$(DESTDIR)$(bindir)" + $(INSTALL) -m 755 $(TOOLS) "$(DESTDIR)$(bindir)" endif ifneq ($(BLOBS),) mkdir -p "$(DESTDIR)$(datadir)" -- 1.6.0.6