From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LnC8d-0000yP-US for qemu-devel@nongnu.org; Fri, 27 Mar 2009 09:30:24 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LnC8X-0000un-Rp for qemu-devel@nongnu.org; Fri, 27 Mar 2009 09:30:22 -0400 Received: from [199.232.76.173] (port=55043 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LnC8X-0000uU-FW for qemu-devel@nongnu.org; Fri, 27 Mar 2009 09:30:17 -0400 Received: from mx2.redhat.com ([66.187.237.31]:43693) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LnC8W-0007MM-SF for qemu-devel@nongnu.org; Fri, 27 Mar 2009 09:30:17 -0400 From: Avi Kivity Date: Fri, 27 Mar 2009 16:30:28 +0300 Message-Id: <1238160630-8745-1-git-send-email-avi@redhat.com> Subject: [Qemu-devel] [PATCH 0/2] Fix immediate error handling on synthetic aios Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel@nongnu.org The block layer can signal aio errors in two ways: by calling the completion function with a negative status code, or by returning a NULL aiocb. Two of the synthetic aio implementations (the DMA API and the vectored aio bouncing) fail to handle the second case correctly, resulting in crashes when cancellation of a timed out request is attempted. I think the long term fix is to have the block layer signal errors in just one way -- by invoking the completion handler with a negative return code -- but in the meanwhile, here are patches that add the required error checking. Avi Kivity (2): Fix vectored aio bounce handling immediate errors Fix DMA API when handling an immediate error from block layer block.c | 5 +++++ dma-helpers.c | 27 +++++++++++++++++++++------ 2 files changed, 26 insertions(+), 6 deletions(-)