From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Lokcc-00068C-CO for qemu-devel@nongnu.org; Tue, 31 Mar 2009 16:31:46 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LokcW-0005zY-Ou for qemu-devel@nongnu.org; Tue, 31 Mar 2009 16:31:45 -0400 Received: from [199.232.76.173] (port=53863 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LokcW-0005zJ-M8 for qemu-devel@nongnu.org; Tue, 31 Mar 2009 16:31:40 -0400 Received: from mx2.redhat.com ([66.187.237.31]:52580) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LokcV-0001Tg-KG for qemu-devel@nongnu.org; Tue, 31 Mar 2009 16:31:39 -0400 From: Glauber Costa Date: Tue, 31 Mar 2009 16:31:34 -0400 Message-Id: <1238531496-4285-2-git-send-email-glommer@redhat.com> In-Reply-To: <1238531496-4285-1-git-send-email-glommer@redhat.com> References: <1238531496-4285-1-git-send-email-glommer@redhat.com> Subject: [Qemu-devel] [PATCH v2 1/3] stop dirty tracking just at the end of migration Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Yaniv Kamay , aliguori@us.ibm.com, Dor Laor , avi@redhat.com If there is still work to do, it is not safe to assume we can end the dirty tracking. Specifically, kvm can update the dirty tracking log inside ram_save_block(), leaving pages still out of sync if we go with the current code. Based on a patch by Yaniv Kamay Signed-off-by: Glauber Costa CC: Yaniv Kamay CC: Dor Laor --- vl.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/vl.c b/vl.c index 5e6c621..1626f8a 100644 --- a/vl.c +++ b/vl.c @@ -3249,10 +3249,10 @@ static int ram_save_live(QEMUFile *f, int stage, void *opaque) /* try transferring iterative blocks of memory */ if (stage == 3) { - cpu_physical_memory_set_dirty_tracking(0); /* flush all remaining blocks regardless of rate limiting */ while (ram_save_block(f) != 0); + cpu_physical_memory_set_dirty_tracking(0); } qemu_put_be64(f, RAM_SAVE_FLAG_EOS); -- 1.5.6.6