From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Lp1AS-0003en-Bv for qemu-devel@nongnu.org; Wed, 01 Apr 2009 10:11:48 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Lp1AN-0003Vw-Lj for qemu-devel@nongnu.org; Wed, 01 Apr 2009 10:11:47 -0400 Received: from [199.232.76.173] (port=57802 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Lp1AN-0003Vg-Hp for qemu-devel@nongnu.org; Wed, 01 Apr 2009 10:11:43 -0400 Received: from ecfrec.frec.bull.fr ([129.183.4.8]:47796) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Lp1AM-0005B0-Rv for qemu-devel@nongnu.org; Wed, 01 Apr 2009 10:11:43 -0400 Received: from cyclope.frec.bull.fr (cyclope.frec.bull.fr [129.183.4.9]) by ecfrec.frec.bull.fr (Postfix) with ESMTP id 05F966F601 for ; Wed, 1 Apr 2009 16:11:32 +0200 (CEST) Received: from [129.183.101.63] (frecb007144.frec.bull.fr [129.183.101.63]) by cyclope.frec.bull.fr (Postfix) with ESMTP id ECE212728D for ; Wed, 1 Apr 2009 16:11:28 +0200 (CEST) Subject: Re: [Qemu-devel] [PATCH] Document QEMU coding style (v2) From: Laurent Vivier In-Reply-To: <20090401133828.GC24403@edgar.se.axis.com> References: <1238520186-2636-1-git-send-email-avi@redhat.com> <20090401133828.GC24403@edgar.se.axis.com> Content-Type: text/plain; charset=utf-8 Date: Wed, 01 Apr 2009 16:13:12 +0200 Message-Id: <1238595192.4648.7.camel@frecb07144> Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Le mercredi 01 avril 2009 =C3=A0 15:38 +0200, Edgar E. Iglesias a =C3=A9c= rit : > On Tue, Mar 31, 2009 at 08:23:06PM +0300, Avi Kivity wrote: > > With the help of some Limoncino I noted several aspects of the QEMU c= oding > > style, particularly where it differs from the Linux coding style as m= any > > contributors work on both projects. > >=20 > > Signed-off-by: Avi Kivity > >=20 > > Changes from v1: > > - s/Qemu/QEMU/ > > - s/Posix/POSIX/ > > - note that the _t suffix is not POSIX compliant, and will be chang= ed > > - discourage eol whitespace > > - be strict about the 80 char line width > > --- > > CODING_STYLE | 78 ++++++++++++++++++++++++++++++++++++++++++++++++= ++++++++++ > > 1 files changed, 78 insertions(+), 0 deletions(-) > > create mode 100644 CODING_STYLE > >=20 > > diff --git a/CODING_STYLE b/CODING_STYLE > > new file mode 100644 > > index 0000000..1ab13b6 > > --- /dev/null > > +++ b/CODING_STYLE > > @@ -0,0 +1,78 @@ > > +Qemu Coding Style > > +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > + > > +1. Whitespace > > + > > +Of course, the most important aspect in any coding style is whitespa= ce. > > +Crusty old coders who have trouble spotting the glasses on their nos= es > > +can tell the difference between a tab and eight spaces from a distan= ce > > +of approximately fifteen parsecs. Many a flamewar have been fought = and > > +lost on this issue. > > + > > +QEMU indents are four spaces. Tabs are never used, except in Makefi= les > > +where they have been irreversibly coded into the syntax by some moro= n. > > +Spaces of course are superior to tabs because: >=20 >=20 > Hi=20 Hi, > I'd appreciate it if we removed the insults and the arrogance, i.e [...] Perhaps it is humor ? (Limoncino doesn't help...) Regards, Laurent --=20 ------------------ Laurent.Vivier@bull.net ------------------ "Tout ce qui est impossible reste =C3=A0 accomplir" Jules Verne "Things are only impossible until they're not" Jean-Luc Picard