From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Lpdn3-00010s-CB
	for qemu-devel@nongnu.org; Fri, 03 Apr 2009 03:26:13 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Lpdmy-0000we-H8
	for qemu-devel@nongnu.org; Fri, 03 Apr 2009 03:26:12 -0400
Received: from [199.232.76.173] (port=56302 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Lpdmy-0000wR-CD
	for qemu-devel@nongnu.org; Fri, 03 Apr 2009 03:26:08 -0400
Received: from mx20.gnu.org ([199.232.41.8]:43290)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <markmc@redhat.com>) id 1Lpdmx-0001BX-Ay
	for qemu-devel@nongnu.org; Fri, 03 Apr 2009 03:26:07 -0400
Received: from mx2.redhat.com ([66.187.237.31])
	by mx20.gnu.org with esmtp (Exim 4.60)
	(envelope-from <markmc@redhat.com>) id 1LpdXi-0005Sr-V6
	for qemu-devel@nongnu.org; Fri, 03 Apr 2009 03:10:24 -0400
Subject: Re: [Qemu-devel] [RFC] Introduce module API to QEMU
From: Mark McLoughlin <markmc@redhat.com>
In-Reply-To: <1238724755-15929-1-git-send-email-aliguori@us.ibm.com>
References: <1238724755-15929-1-git-send-email-aliguori@us.ibm.com>
Content-Type: text/plain
Date: Fri, 03 Apr 2009 08:08:16 +0100
Message-Id: <1238742496.2510.22.camel@blaa>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Reply-To: Mark McLoughlin <markmc@redhat.com>, qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Anthony Liguori <aliguori@us.ibm.com>, Paul Brook <paul@codesourcery.com>

Hey,

Generally looks good to me.

On Thu, 2009-04-02 at 21:12 -0500, Anthony Liguori wrote:
> diff --git a/hw/mcf_fec.c b/hw/mcf_fec.c
> index 413c569..49ae69b 100644
> --- a/hw/mcf_fec.c
> +++ b/hw/mcf_fec.c
> @@ -446,8 +446,6 @@ void mcf_fec_init(NICInfo *nd, target_phys_addr_t base, qemu_irq *irq)
>      mcf_fec_state *s;
>      int iomemtype;
>  
> -    qemu_check_nic_model(nd, "mcf_fec");

It's obscure, but this line does three things:

  1) Makes 'qemu-system-m68k -net nic,model=?' list the available model

  2) Makes 'qemu-system-m68k -net nic,model=e1000' fail

  3) Makes 'qemu-system-m68k -net nic' have sane 'info network' output 
     - i.e. the model is listed as mcf_fec

That goes for the other non-PCI NICs too.

Cheers,
Mark.