From: Ed Swierk <eswierk@aristanetworks.com>
To: bochs-developers@lists.sourceforge.net, qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH] Fix timer interrupt routing for non-ACPI guest
Date: Fri, 10 Apr 2009 20:08:38 -0700 [thread overview]
Message-ID: <1239419318.20633.10.camel@localhost.localdomain> (raw)
Qemu 0.10.2 is unable to boot a non-ACPI kernel due to a BIOS bug:
ENABLING IO-APIC IRQs
..TIMER: vector=0x31 apic1=0 pin1=0 apic2=-1 pin2=-1
..MP-BIOS bug: 8254 timer not connected to IO-APIC
...trying to set up timer (IRQ0) through the 8259A ...
..... (found apic 0 pin 0) ...
....... failed.
...trying to set up timer as Virtual Wire IRQ...
The interrupt routing table in the MPTABLE needs to route the timer
interrupt (IRQ 0) to IOAPIC pin 2.
A similar bug was recently fixed in the ACPI table code. This patch
fixes the problem for non-ACPI guests.
Signed-off-by: Ed Swierk <eswierk@aristanetworks.com>
---
diff --git a/bios/rombios32.c b/bios/rombios32.c
index 7be4216..13d5435 100644
--- a/bios/rombios32.c
+++ b/bios/rombios32.c
@@ -1173,7 +1173,7 @@ static void mptable_init(void)
putb(&q, 0); /* flags: po=0, el=0 */
putb(&q, 0);
putb(&q, 0); /* source bus ID = ISA */
- putb(&q, i); /* source bus IRQ */
+ putb(&q, i == 2 ? 0 : i); /* source bus IRQ */
putb(&q, ioapic_id); /* dest I/O APIC ID */
putb(&q, i); /* dest I/O APIC interrupt in */
}
next reply other threads:[~2009-04-11 3:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-11 3:08 Ed Swierk [this message]
2009-04-12 13:51 ` [Qemu-devel] Re: [PATCH] Fix timer interrupt routing for non-ACPI guest Sebastian Herbszt
2009-04-12 21:46 ` Ed Swierk
2009-04-13 15:49 ` Sebastian Herbszt
2009-04-13 16:21 ` [Qemu-devel] " Beth Kon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1239419318.20633.10.camel@localhost.localdomain \
--to=eswierk@aristanetworks.com \
--cc=bochs-developers@lists.sourceforge.net \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).