From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Lu50L-0005ma-VF
	for qemu-devel@nongnu.org; Wed, 15 Apr 2009 09:18:18 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Lu50H-0005k7-5D
	for qemu-devel@nongnu.org; Wed, 15 Apr 2009 09:18:17 -0400
Received: from [199.232.76.173] (port=44441 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Lu50G-0005jp-QB
	for qemu-devel@nongnu.org; Wed, 15 Apr 2009 09:18:12 -0400
Received: from mx2.redhat.com ([66.187.237.31]:56879)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <markmc@redhat.com>) id 1Lu50F-0007f9-5R
	for qemu-devel@nongnu.org; Wed, 15 Apr 2009 09:18:11 -0400
Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26])
	by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n3FDIApX029406
	for <qemu-devel@nongnu.org>; Wed, 15 Apr 2009 09:18:10 -0400
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199])
	by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n3FDI92r005679
	for <qemu-devel@nongnu.org>; Wed, 15 Apr 2009 09:18:09 -0400
Received: from [127.0.0.1] (file.rdu.redhat.com [10.11.255.147])
	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n3FDI8iR008247
	for <qemu-devel@nongnu.org>; Wed, 15 Apr 2009 09:18:08 -0400
Subject: Re: [Qemu-devel] [PATCH 6/7] net: Add support for capturing VLANs
From: Mark McLoughlin <markmc@redhat.com>
In-Reply-To: <20090414172955.15035.35614.stgit@mchn012c.ww002.siemens.net>
References: <20090414172954.15035.73053.stgit@mchn012c.ww002.siemens.net>
	<20090414172955.15035.35614.stgit@mchn012c.ww002.siemens.net>
Content-Type: text/plain
Date: Wed, 15 Apr 2009 14:10:06 +0100
Message-Id: <1239801006.4431.132.camel@blaa>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Reply-To: Mark McLoughlin <markmc@redhat.com>, qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On Tue, 2009-04-14 at 19:29 +0200, Jan Kiszka wrote:
> This patch is derived from Tristan Gingold's patch. It adds a new VLAN
> client type that writes all traffic on the VLAN it is attached to into a
> pcap file. Such a file can then be analyzed offline with Wireshark or
> tcpdump.

Personally, I'd use a tap device and 'tcpdump -w' to do this.

Any particular reason to add support to qemu itself other than
convenience?

> Besides rebasing and some minor cleanups, the major differences to the
> original version are:
>  - support for enabling/disabling via the monitor (host_net_add/remove)
>  - always register dump client at the head of a VLAN queue
>    (instead of special handling for slirp)

Could you explain why you need this? 

I'd prefer if we didn't have to add qemu_new_vlan_head_client()

Cheers,
Mark.