qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Glauber Costa <glommer@redhat.com>
To: qemu-devel@nongnu.org
Cc: jan.kiszka@siemens.com, aliguori@us.ibm.com
Subject: [Qemu-devel] [PATCH 2/6] always have apic
Date: Fri, 17 Apr 2009 11:20:45 -0400	[thread overview]
Message-ID: <1239981649-6366-3-git-send-email-glommer@redhat.com> (raw)
In-Reply-To: <1239981649-6366-2-git-send-email-glommer@redhat.com>

if we are going to initialize the apic, set cpuid bit unconditionally.
As far as I know, we should not do that for isa machines anyway.

Signed-off-by: Glauber Costa <glommer@redhat.com>
---
 hw/pc.c |    6 ++----
 1 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/hw/pc.c b/hw/pc.c
index 39ed066..7649f2c 100644
--- a/hw/pc.c
+++ b/hw/pc.c
@@ -784,12 +784,10 @@ CPUState *pc_new_cpu(int cpu, const char *cpu_model, int pci_enabled)
     }
     if (cpu != 0)
         env->halted = 1;
-    if (smp_cpus > 1) {
-        /* XXX: enable it in all cases */
-        env->cpuid_features |= CPUID_APIC;
-    }
+
     qemu_register_reset(main_cpu_reset, env);
     if (pci_enabled) {
+        env->cpuid_features |= CPUID_APIC;
         apic_init(env);
     }
     return env;
-- 
1.5.6.6

  reply	other threads:[~2009-04-17 15:21 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-17 15:20 [Qemu-devel] [PATCH 0/6] Add support for cpu hotplug Glauber Costa
2009-04-17 15:20 ` [Qemu-devel] [PATCH 1/6] split pc_new_cpu Glauber Costa
2009-04-17 15:20   ` Glauber Costa [this message]
2009-04-17 15:20     ` [Qemu-devel] [PATCH 3/6] Fix warnings and errors with DEBUG enabled Glauber Costa
2009-04-17 15:20       ` [Qemu-devel] [PATCH 4/6] disallow kqemu if we fail to load it Glauber Costa
2009-04-17 15:20         ` [Qemu-devel] [PATCH 5/6] enable cpu hotplug Glauber Costa
2009-04-17 15:20           ` [Qemu-devel] [PATCH 6/6] add bios support for " Glauber Costa
2009-04-17 20:06             ` [Qemu-devel] " Anthony Liguori
2009-04-17 20:18           ` [Qemu-devel] Re: [PATCH 5/6] enable " Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1239981649-6366-3-git-send-email-glommer@redhat.com \
    --to=glommer@redhat.com \
    --cc=aliguori@us.ibm.com \
    --cc=jan.kiszka@siemens.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).