From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LuvAe-0005nc-8g for qemu-devel@nongnu.org; Fri, 17 Apr 2009 17:00:24 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LuvAY-0005jG-AA for qemu-devel@nongnu.org; Fri, 17 Apr 2009 17:00:23 -0400 Received: from [199.232.76.173] (port=58336 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LuvAY-0005j8-1R for qemu-devel@nongnu.org; Fri, 17 Apr 2009 17:00:18 -0400 Received: from mx2.redhat.com ([66.187.237.31]:52349) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LuvAV-0000Ig-Vi for qemu-devel@nongnu.org; Fri, 17 Apr 2009 17:00:17 -0400 From: Glauber Costa Date: Fri, 17 Apr 2009 17:00:07 -0400 Message-Id: <1240002008-2351-5-git-send-email-glommer@redhat.com> In-Reply-To: <1240002008-2351-4-git-send-email-glommer@redhat.com> References: <1240002008-2351-1-git-send-email-glommer@redhat.com> <1240002008-2351-2-git-send-email-glommer@redhat.com> <1240002008-2351-3-git-send-email-glommer@redhat.com> <1240002008-2351-4-git-send-email-glommer@redhat.com> Subject: [Qemu-devel] [PATCH v2 4/5] disallow kqemu if we fail to load it. Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: aliguori@us.ibm.com Since we're not retrying it anyway, set kqemu_allowed = 0 if we fail to load it. It will allow us to test for kqemu runtime presence where we don't have an env pointer, possibly because we don't have a cpu yet. The monitor code is such an example. Signed-off-by: Glauber Costa --- kqemu.c | 6 ++++-- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/kqemu.c b/kqemu.c index 040e817..e0e0499 100644 --- a/kqemu.c +++ b/kqemu.c @@ -179,14 +179,14 @@ int kqemu_init(CPUState *env) if (kqemu_fd == KQEMU_INVALID_FD) { fprintf(stderr, "Could not open '%s' - QEMU acceleration layer not activated: %lu\n", KQEMU_DEVICE, GetLastError()); - return -1; + goto out; } #else kqemu_fd = open(KQEMU_DEVICE, O_RDWR); if (kqemu_fd == KQEMU_INVALID_FD) { fprintf(stderr, "Could not open '%s' - QEMU acceleration layer not activated: %s\n", KQEMU_DEVICE, strerror(errno)); - return -1; + goto out; } #endif version = 0; @@ -239,6 +239,8 @@ int kqemu_init(CPUState *env) fail: kqemu_closefd(kqemu_fd); kqemu_fd = KQEMU_INVALID_FD; + out: + kqemu_allowed = 0; return -1; } kqemu_update_cpuid(env); -- 1.5.6.6