qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paul Bolle <pebolle@tiscali.nl>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH] kqemu: only compile kqemu.o if actually needed
Date: Sat, 18 Apr 2009 13:54:29 +0200	[thread overview]
Message-ID: <1240055669.12170.20.camel@localhost.localdomain> (raw)

kqemu.o is compiled even if kqemu support is disabled. This is useless
(kqemu.o should provide nothing that is actually used in that case) and
slightly confusing. So introduce CONFIG_KQEMU for optionally compiling
kqemu.o.

Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
---
If this is accepted a next step could be to merge CONFIG_KQEMU and
USE_KQEMU.

 Makefile.target |    5 ++++-
 configure       |    2 ++
 2 files changed, 6 insertions(+), 1 deletions(-)

diff --git a/Makefile.target b/Makefile.target
index dae339b..b27696a 100644
--- a/Makefile.target
+++ b/Makefile.target
@@ -131,8 +131,11 @@ all: $(PROGS)
 
 #########################################################
 # cpu emulator library
-LIBOBJS=exec.o kqemu.o translate-all.o cpu-exec.o\
+LIBOBJS=exec.o translate-all.o cpu-exec.o\
         translate.o host-utils.o
+ifdef CONFIG_KQEMU
+LIBOBJS+= kqemu.o
+endif
 # TCG code generator
 LIBOBJS+= tcg/tcg.o tcg/tcg-runtime.o
 CPPFLAGS+=-I$(SRC_PATH)/tcg -I$(SRC_PATH)/tcg/$(ARCH)
diff --git a/configure b/configure
index af35713..1d96635 100755
--- a/configure
+++ b/configure
@@ -1766,6 +1766,7 @@ case "$target_cpu" in
     echo "#define TARGET_I386 1" >> $config_h
     if test $kqemu = "yes" -a "$target_softmmu" = "yes"
     then
+      echo "CONFIG_KQEMU=yes" >> $config_mak
       echo "#define USE_KQEMU 1" >> $config_h
     fi
     if test "$kvm" = "yes" ; then
@@ -1781,6 +1782,7 @@ case "$target_cpu" in
     echo "#define TARGET_X86_64 1" >> $config_h
     if test $kqemu = "yes" -a "$target_softmmu" = "yes" -a $cpu = "x86_64"
     then
+      echo "CONFIG_KQEMU=yes" >> $config_mak
       echo "#define USE_KQEMU 1" >> $config_h
     fi
     if test "$kvm" = "yes" ; then
-- 
1.6.2.2

             reply	other threads:[~2009-04-18 11:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-18 11:54 Paul Bolle [this message]
2009-04-18 19:26 ` [Qemu-devel] [PATCH] kqemu: only compile kqemu.o if actually needed Blue Swirl
2009-04-18 21:51   ` [Qemu-devel] [PATCH] kqemu: merge CONFIG_KQEMU and USE_KQEMU Paul Bolle
2009-04-19 10:18     ` [Qemu-devel] " Blue Swirl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1240055669.12170.20.camel@localhost.localdomain \
    --to=pebolle@tiscali.nl \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).