From: Glauber Costa <glommer@redhat.com>
To: qemu-devel@nongnu.org
Cc: aliguori@us.ibm.com
Subject: [Qemu-devel] [PATCH] suport device driver initialization model
Date: Thu, 23 Apr 2009 15:20:55 -0400 [thread overview]
Message-ID: <1240514455-30955-1-git-send-email-glommer@redhat.com> (raw)
According to PnP specification, Appendix B, Option ROMs
that support DDIM (device driver initialization model) should
have their memory space writeable.
KVM deviates from us here, by removing the IO_MEM_ROM flag,
to allow for PCI option ROMs (they require DDIM). However,
there's absolutely no reason we can't do the same.
Signed-off-by: Glauber Costa <glommer@redhat.com>
---
hw/pc.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/hw/pc.c b/hw/pc.c
index 4463bdb..19a122a 100644
--- a/hw/pc.c
+++ b/hw/pc.c
@@ -924,8 +924,7 @@ static void pc_init1(ram_addr_t ram_size, int vga_ram_size,
option_rom_offset = qemu_ram_alloc(0x20000);
oprom_area_size = 0;
- cpu_register_physical_memory(0xc0000, 0x20000,
- option_rom_offset | IO_MEM_ROM);
+ cpu_register_physical_memory(0xc0000, 0x20000, option_rom_offset);
if (using_vga) {
/* VGA BIOS load */
--
1.5.6.6
reply other threads:[~2009-04-23 19:21 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1240514455-30955-1-git-send-email-glommer@redhat.com \
--to=glommer@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).