From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Lx4Tw-0006qR-9h for qemu-devel@nongnu.org; Thu, 23 Apr 2009 15:21:12 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Lx4Tr-0006ph-6G for qemu-devel@nongnu.org; Thu, 23 Apr 2009 15:21:11 -0400 Received: from [199.232.76.173] (port=38934 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Lx4Tr-0006pe-0W for qemu-devel@nongnu.org; Thu, 23 Apr 2009 15:21:07 -0400 Received: from mx2.redhat.com ([66.187.237.31]:44055) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Lx4To-0006Ay-EZ for qemu-devel@nongnu.org; Thu, 23 Apr 2009 15:21:06 -0400 From: Glauber Costa Date: Thu, 23 Apr 2009 15:20:55 -0400 Message-Id: <1240514455-30955-1-git-send-email-glommer@redhat.com> Subject: [Qemu-devel] [PATCH] suport device driver initialization model List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: aliguori@us.ibm.com According to PnP specification, Appendix B, Option ROMs that support DDIM (device driver initialization model) should have their memory space writeable. KVM deviates from us here, by removing the IO_MEM_ROM flag, to allow for PCI option ROMs (they require DDIM). However, there's absolutely no reason we can't do the same. Signed-off-by: Glauber Costa --- hw/pc.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/hw/pc.c b/hw/pc.c index 4463bdb..19a122a 100644 --- a/hw/pc.c +++ b/hw/pc.c @@ -924,8 +924,7 @@ static void pc_init1(ram_addr_t ram_size, int vga_ram_size, option_rom_offset = qemu_ram_alloc(0x20000); oprom_area_size = 0; - cpu_register_physical_memory(0xc0000, 0x20000, - option_rom_offset | IO_MEM_ROM); + cpu_register_physical_memory(0xc0000, 0x20000, option_rom_offset); if (using_vga) { /* VGA BIOS load */ -- 1.5.6.6