qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [Qemu-devel] [PATCH] suport device driver initialization model
@ 2009-04-23 19:20 Glauber Costa
  0 siblings, 0 replies; only message in thread
From: Glauber Costa @ 2009-04-23 19:20 UTC (permalink / raw)
  To: qemu-devel; +Cc: aliguori

According to PnP specification, Appendix B, Option ROMs
that support DDIM (device driver initialization model) should
have their memory space writeable.

KVM deviates from us here, by removing the IO_MEM_ROM flag,
to allow for PCI option ROMs (they require DDIM). However,
there's absolutely no reason we can't do the same.

Signed-off-by: Glauber Costa <glommer@redhat.com>
---
 hw/pc.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/hw/pc.c b/hw/pc.c
index 4463bdb..19a122a 100644
--- a/hw/pc.c
+++ b/hw/pc.c
@@ -924,8 +924,7 @@ static void pc_init1(ram_addr_t ram_size, int vga_ram_size,
 
     option_rom_offset = qemu_ram_alloc(0x20000);
     oprom_area_size = 0;
-    cpu_register_physical_memory(0xc0000, 0x20000,
-                                 option_rom_offset | IO_MEM_ROM);
+    cpu_register_physical_memory(0xc0000, 0x20000, option_rom_offset);
 
     if (using_vga) {
         /* VGA BIOS load */
-- 
1.5.6.6

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2009-04-23 19:21 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-04-23 19:20 [Qemu-devel] [PATCH] suport device driver initialization model Glauber Costa

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).