From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LxItO-0004Dc-RQ for qemu-devel@nongnu.org; Fri, 24 Apr 2009 06:44:26 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LxItJ-0004DQ-Cw for qemu-devel@nongnu.org; Fri, 24 Apr 2009 06:44:25 -0400 Received: from [199.232.76.173] (port=39151 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LxItJ-0004DN-6y for qemu-devel@nongnu.org; Fri, 24 Apr 2009 06:44:21 -0400 Received: from smtp-out2.tiscali.nl ([195.241.79.177]:33112) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LxItI-0001Wm-Na for qemu-devel@nongnu.org; Fri, 24 Apr 2009 06:44:20 -0400 Subject: Re: [Qemu-devel] [BUG] -usb makes qemu fight against linux From: Paul Bolle In-Reply-To: <1240567553.24225.11.camel@localhost.localdomain> References: <49B0E4C9.70002@sbeh.de> <1240567553.24225.11.camel@localhost.localdomain> Content-Type: text/plain Date: Fri, 24 Apr 2009 12:44:17 +0200 Message-Id: <1240569857.24225.19.camel@localhost.localdomain> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stan Behrens Cc: qemu-devel@nongnu.org On Fri, 2009-04-24 at 12:05 +0200, Paul Bolle wrote: > On Fri, 2009-03-06 at 09:54 +0100, Stan Behrens wrote: > This seems related to this discussion: > http://lists.gnu.org/archive/html/qemu-devel/2008-10/msg01320.html (in a > thread regarding a preliminary patch to implement ehci). > > Could you try the following patch? It was created after finally > discovering the discussion mentioned above (which I hardly understand, > which in turn leads to an impressive, but possibly nonsensical commit > message for this patch). It seems to fix a similar issue I ran into > (while trying some advanced feature of a USB memory stick I happen to > have.) I just found a slightly different and, I guess, better solution here: http://lists.gnu.org/archive/html/qemu-devel/2008-10/msg01326.html (I seem to have missed this messages in that archive as it is, for some reason, a separate thread). I simply copied it from that address into this mail. It will probably not apply without manual adjustments. Paul Bolle --- Index: usb-linux.c =================================================================== --- usb-linux.c (revision 5571) +++ usb-linux.c (working copy) @@ -68,7 +68,7 @@ static int usb_host_find_device(int *pbus_num, int *paddr, char *product_name, int product_name_size, const char *devname); -//#define DEBUG +// #define DEBUG #ifdef DEBUG #define dprintf printf @@ -276,7 +276,9 @@ case -EPIPE: set_halt(s, p->devep); - /* fall through */ + p->len = USB_RET_STALL; + break; + default: p->len = USB_RET_NAK; break;