From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LyVCm-00079a-AX for qemu-devel@nongnu.org; Mon, 27 Apr 2009 14:05:24 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LyVCh-00078T-Gp for qemu-devel@nongnu.org; Mon, 27 Apr 2009 14:05:23 -0400 Received: from [199.232.76.173] (port=51598 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LyVCh-00078Q-8N for qemu-devel@nongnu.org; Mon, 27 Apr 2009 14:05:19 -0400 Received: from mail.corp.accelance.fr ([213.162.48.15]:62375) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LyVCg-0007kz-B0 for qemu-devel@nongnu.org; Mon, 27 Apr 2009 14:05:18 -0400 Subject: Re: [Qemu-devel] [PATCH] linux-user: Added IP_ADD_MEMBERSHIP/IP_DROP_MEMBERSHIP flags to setsockopt From: Lionel Landwerlin In-Reply-To: <20090427172134.GA23911@codesourcery.com> References: <1240695019.21332.1.camel@coalu.atr> <20090427172134.GA23911@codesourcery.com> Content-Type: text/plain; charset="UTF-8" Date: Mon, 27 Apr 2009 20:05:06 +0200 Message-Id: <1240855506.29022.1.camel@coalu.atr> Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Nathan Froyd , qemu-devel@nongnu.org Le lundi 27 avril 2009 =C3=A0 10:21 -0700, Nathan Froyd a =C3=A9crit : > On Sat, Apr 25, 2009 at 11:30:19PM +0200, Lionel Landwerlin wrote: > > linux-user: Added IP_ADD_MEMBERSHIP/IP_DROP_MEMBERSHIP flags to setso= ckopt >=20 > Should these be TARGET_IP_* instead, or are they like the FUTEX_* > constants and the same on every platform? If the latter, at the very > least there should be explanatory comments somewhere--just making them > TARGET_IP_* would be even better, IMHO. >=20 > -Nathan >=20 >=20 I'm agree too, I just did the way it was before... --=20 Lionel Landwerlin