From: Amit Shah <amit.shah@redhat.com>
To: anthony@codemonkey.cs
Cc: Amit Shah <amit.shah@redhat.com>, qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH] e1000: Do not reinit pci config space to 0
Date: Mon, 4 May 2009 18:02:04 +0530 [thread overview]
Message-ID: <1241440324-12560-1-git-send-email-amit.shah@redhat.com> (raw)
pci_register_device already mallocs the pci config space buffer filled
with zeroes.
Doing this again breaks some default config space writes like
setting the subsystem vendor id and subsystem device id.
Signed-off-by: Amit Shah <amit.shah@redhat.com>
---
hw/e1000.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/hw/e1000.c b/hw/e1000.c
index b0fe917..940e893 100644
--- a/hw/e1000.c
+++ b/hw/e1000.c
@@ -1067,7 +1067,6 @@ pci_e1000_init(PCIBus *bus, NICInfo *nd, int devfn)
return NULL;
pci_conf = d->dev.config;
- memset(pci_conf, 0, 256);
pci_config_set_vendor_id(pci_conf, PCI_VENDOR_ID_INTEL);
pci_config_set_device_id(pci_conf, E1000_DEVID);
--
1.6.0.6
reply other threads:[~2009-05-04 12:32 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1241440324-12560-1-git-send-email-amit.shah@redhat.com \
--to=amit.shah@redhat.com \
--cc=anthony@codemonkey.cs \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).