* [Qemu-devel] [PATCH] e1000: Do not reinit pci config space to 0
@ 2009-05-04 12:32 Amit Shah
0 siblings, 0 replies; only message in thread
From: Amit Shah @ 2009-05-04 12:32 UTC (permalink / raw)
To: anthony; +Cc: Amit Shah, qemu-devel
pci_register_device already mallocs the pci config space buffer filled
with zeroes.
Doing this again breaks some default config space writes like
setting the subsystem vendor id and subsystem device id.
Signed-off-by: Amit Shah <amit.shah@redhat.com>
---
hw/e1000.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/hw/e1000.c b/hw/e1000.c
index b0fe917..940e893 100644
--- a/hw/e1000.c
+++ b/hw/e1000.c
@@ -1067,7 +1067,6 @@ pci_e1000_init(PCIBus *bus, NICInfo *nd, int devfn)
return NULL;
pci_conf = d->dev.config;
- memset(pci_conf, 0, 256);
pci_config_set_vendor_id(pci_conf, PCI_VENDOR_ID_INTEL);
pci_config_set_device_id(pci_conf, E1000_DEVID);
--
1.6.0.6
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2009-05-04 12:32 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-05-04 12:32 [Qemu-devel] [PATCH] e1000: Do not reinit pci config space to 0 Amit Shah
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).