From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1M3QWw-0005yQ-At
	for qemu-devel@nongnu.org; Mon, 11 May 2009 04:06:34 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1M3QWt-0005yE-Uc
	for qemu-devel@nongnu.org; Mon, 11 May 2009 04:06:34 -0400
Received: from [199.232.76.173] (port=47637 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1M3QWt-0005yB-Rj
	for qemu-devel@nongnu.org; Mon, 11 May 2009 04:06:31 -0400
Received: from mailgw3.cms.com ([202.75.200.223]:13106 helo=cms.com)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <vibi_sreenivasan@cms.com>) id 1M3QWq-0006mG-M1
	for qemu-devel@nongnu.org; Mon, 11 May 2009 04:06:30 -0400
Subject: Re: [Qemu-devel][PATCH]: Fix in file qemu-sockets.c
From: vibisreenivasan <vibi_sreenivasan@cms.com>
In-Reply-To: <4A07C330.101@redhat.com>
References: <200905061527.03395.vibi_sreenivasan@cms.com>
	<4A07C330.101@redhat.com>
Content-Type: text/plain
Date: Mon, 11 May 2009 12:31:24 +0530
Message-Id: <1242025284.4546.3.camel@system>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Resent-Message-Id: <E1M3QWt-0005yE-Uc@lists.gnu.org>
Reply-To: vibi_sreenivasan@cms.com
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org

hi,
	
On 05/06/09 11:57, vibi wrote:
>> 	1) Changed usage of malloc,free,strdup to qemu_malloc,qemu_free,qemu_strdup
>>   	2) Some coding style fixes (based on CODING_STYLE document)

>Mixing such cleanups with actual code changes makes review very hard. 
>Better send whitespace/formating cleanups separate from code fixes.

Thanks for looking into that code.
I will separate the patches & send it again.

Thanks & Regards
vibi