From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1M3oM5-0007JG-2Z
	for qemu-devel@nongnu.org; Tue, 12 May 2009 05:32:57 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1M3oLz-0007FP-M2
	for qemu-devel@nongnu.org; Tue, 12 May 2009 05:32:56 -0400
Received: from [199.232.76.173] (port=33057 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1M3oLz-0007FE-HD
	for qemu-devel@nongnu.org; Tue, 12 May 2009 05:32:51 -0400
Received: from smtp-out3.tiscali.nl ([195.241.79.178]:35792)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <pebolle@tiscali.nl>) id 1M3oLz-0000W6-4E
	for qemu-devel@nongnu.org; Tue, 12 May 2009 05:32:51 -0400
Subject: Re: [Qemu-devel] [PATCH] EHCI emulation module for review
From: Paul Bolle <pebolle@tiscali.nl>
In-Reply-To: <1240874133.28148.62.camel@x41.thuisdomein>
References: <o4ikg45ccdvu5ttfpb1nhfi9ub9ekhu89t@4ax.com>
	<1240874133.28148.62.camel@x41.thuisdomein>
Content-Type: text/plain
Date: Tue, 12 May 2009 11:32:47 +0200
Message-Id: <1242120767.7568.18.camel@localhost.localdomain>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Mark Burkley <qemu@emutex.com>
Cc: qemu-devel@nongnu.org

On Tue, 2009-04-28 at 01:15 +0200, Paul Bolle wrote:
> On Fri, 2008-10-31 at 00:05 +0000, Mark Burkley wrote:
> > I just tested with a host usb msd device under FC8 and it works fine
> > with a WinXP target.
> 
> [...]
>
> I should note that after fixing those issues I could get a Fedora 11
> Beta guest to notice the EHCI host controller but it somehow never
> noticed devices I added. I have not yet investigated what is (not) going
> on there.

I pinpointed that one to the fact that the current (for review) code
uses the IRQ pins inconsistently (or however that could best be
described). This seems to fix it for me:

@@ -2013,7 +2030,7 @@ void usb_ehci_init(PCIBus *bus, int devfn)
     ehci->mmio[0x0a] = 0x00;
     ehci->mmio[0x0b] = 0x00;
 
-    ehci->irq = ehci->dev.irq[0];
+    ehci->irq = ehci->dev.irq[3];
 
     // TODO - port registration is going to need an overhaul since ports
     // can be low, full or high speed and are not tied to UHCI or EHCI.   

I guess this isn't an issue with a Windows XP guest because it (somehow)
works around the issue of never receiving interrupts from the EHCI host
controller.

Paul Bolle