From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1M4Fw4-0000Gt-Kc for qemu-devel@nongnu.org; Wed, 13 May 2009 10:59:56 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1M4Fw0-0000EU-38 for qemu-devel@nongnu.org; Wed, 13 May 2009 10:59:56 -0400 Received: from [199.232.76.173] (port=37699 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M4Fvz-0000EH-Ps for qemu-devel@nongnu.org; Wed, 13 May 2009 10:59:51 -0400 Received: from mx2.redhat.com ([66.187.237.31]:40111) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1M4Fvz-00038v-AT for qemu-devel@nongnu.org; Wed, 13 May 2009 10:59:51 -0400 From: Mark McLoughlin In-Reply-To: <20090513150145.GC27295@poweredge.glommer> References: <1242225826-15384-1-git-send-email-aliguori@us.ibm.com> <1242225826-15384-3-git-send-email-aliguori@us.ibm.com> <20090513150145.GC27295@poweredge.glommer> Content-Type: text/plain Date: Wed, 13 May 2009 15:59:47 +0100 Message-Id: <1242226787.27745.12.camel@blaa> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 2/2] reset state for load_linux Reply-To: Mark McLoughlin List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Glauber Costa Cc: Anthony Liguori , qemu-devel@nongnu.org On Wed, 2009-05-13 at 12:01 -0300, Glauber Costa wrote: > On Wed, May 13, 2009 at 09:43:46AM -0500, Anthony Liguori wrote: > > From: Glauber Costa > > > > The linux loader is just an option rom like any other, just with > > some special requirements. Right now, our option rom resetting > > mechanism is not being applied to it. As a result, users using > > -kernel will not be able to successfully reboot their machines > > > > This patch fixes it by saving all the data we generated in > > the load_linux() function, to be used later by the option rom > > resetting mechanism. > > > > This also includes Mark's fix for -kernel > Just to be clear: > > We just need mark's fix in stable, right? Yep, the code looks right in master and I'm pretty sure I tested it too. Cheers, Mark.