From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1M4Yc1-0001Sv-2i
	for qemu-devel@nongnu.org; Thu, 14 May 2009 06:56:29 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1M4Ybw-0001RS-MW
	for qemu-devel@nongnu.org; Thu, 14 May 2009 06:56:28 -0400
Received: from [199.232.76.173] (port=52194 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1M4Ybw-0001RO-Ea
	for qemu-devel@nongnu.org; Thu, 14 May 2009 06:56:24 -0400
Received: from mail02.svc.cra.dublin.eircom.net ([159.134.118.18]:48189)
	by monty-python.gnu.org with smtp (Exim 4.60)
	(envelope-from <markmc@redhat.com>) id 1M4Ybw-0000Mh-0W
	for qemu-devel@nongnu.org; Thu, 14 May 2009 06:56:24 -0400
From: Mark McLoughlin <markmc@redhat.com>
Date: Thu, 14 May 2009 11:56:17 +0100
Message-Id: <1242298581-30587-1-git-send-email-markmc@redhat.com>
In-Reply-To: <1240265600-9469-1-git-send-email-ryanh@us.ibm.com>
References: <1240265600-9469-1-git-send-email-ryanh@us.ibm.com>
Subject: [Qemu-devel] [STABLE][PATCH 0/4] Rebase more aio dma cancellation
	work
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: qemu-devel@nongnu.org, Avi Kivity <avi@redhat.com>


Hi,
        We've a report of F11 qemu segfaulting when using read-only
images here:

   https://bugzilla.redhat.com/497170

        Looking at the current code in stable, there is clearly some
borkage:

  - No error handling in bdrv_aio_rw_vector()

  - No error handling in dma_bdrv_cb()/dma_bdrv_io()

  - VectorTranslationState is leaked by bdrv_aio_rw_vector_cb()

  - dma_aio_cancel() is cancelling the wrong aio

       The rest of Avi's aio cancellation patches actually fixes all
these problems. Please apply to stable.

Cheers,
Mark.