qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Mark McLoughlin <markmc@redhat.com>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: qemu-devel@nongnu.org, Avi Kivity <avi@redhat.com>
Subject: [Qemu-devel] [STABLE][PATCH 3/4] Fix vectored aio bounce handling immediate errors
Date: Thu, 14 May 2009 11:56:20 +0100	[thread overview]
Message-ID: <1242298581-30587-4-git-send-email-markmc@redhat.com> (raw)
In-Reply-To: <1242298581-30587-3-git-send-email-markmc@redhat.com>

From: Avi Kivity <avi@redhat.com>

If a bounced vectored aio fails immediately (the inner aio submission
returning NULL) then the bounce handler erronously returns an aio
request which will never be completed (and which crashes when cancelled).

Fix by detecting that the inner request has failed and propagating the
error.

Signed-off-by: Avi Kivity <avi@redhat.com>

---
 block.c |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/block.c b/block.c
index 689ea37..b68a8da 100644
--- a/block.c
+++ b/block.c
@@ -1383,6 +1383,11 @@ static BlockDriverAIOCB *bdrv_aio_rw_vector(BlockDriverState *bs,
         s->aiocb = bdrv_aio_read(bs, sector_num, s->bounce, nb_sectors,
                                  bdrv_aio_rw_vector_cb, s);
     }
+    if (!s->aiocb) {
+        qemu_vfree(s->bounce);
+        qemu_aio_release(s);
+        return NULL;
+    }
     return &s->common;
 }
 
-- 
1.6.0.6

  reply	other threads:[~2009-05-14 10:56 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-20 22:13 [Qemu-devel] [STABLE][PATCH 0/3] Rebase aio dma cancellation work Ryan Harper
2009-04-20 22:13 ` [Qemu-devel] [STABLE][PATCH 1/3] Refactor aio callback allocation to use an aiocb pool Ryan Harper
2009-04-20 22:13 ` [Qemu-devel] [STABLE][PATCH 2/3] Convert vectored aio emulation to use a dedicated pool Ryan Harper
2009-04-20 22:13 ` [Qemu-devel] [STABLE][PATCH 3/3] Implement cancellation method for dma async I/O Ryan Harper
2009-04-21 21:35 ` [Qemu-devel] Re: [STABLE][PATCH 0/3] Rebase aio dma cancellation work Anthony Liguori
2009-04-22 11:03   ` Avi Kivity
2009-05-14 10:56 ` [Qemu-devel] [STABLE][PATCH 0/4] Rebase more " Mark McLoughlin
2009-05-14 10:56   ` [Qemu-devel] [STABLE][PATCH 1/4] Use vectored aiocb storage to store vector translation state Mark McLoughlin
2009-05-14 10:56     ` [Qemu-devel] [STABLE][PATCH 2/4] Move block dma helpers aiocb to store dma state Mark McLoughlin
2009-05-14 10:56       ` Mark McLoughlin [this message]
2009-05-14 10:56         ` [Qemu-devel] [STABLE][PATCH 4/4] Fix DMA API when handling an immediate error from block layer Mark McLoughlin
2009-05-14 11:39           ` Mark McLoughlin
2009-05-14 11:39         ` [Qemu-devel] [STABLE][PATCH 3/4] Fix vectored aio bounce handling immediate errors Mark McLoughlin
2009-05-14 11:39       ` [Qemu-devel] [STABLE][PATCH 2/4] Move block dma helpers aiocb to store dma state Mark McLoughlin
2009-05-14 11:38     ` [Qemu-devel] [STABLE][PATCH 1/4] Use vectored aiocb storage to store vector translation state Mark McLoughlin
2009-05-14 11:28   ` [Qemu-devel] Re: [STABLE][PATCH 0/4] Rebase more aio dma cancellation work Avi Kivity
2009-05-14 14:38   ` [Qemu-devel] " Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1242298581-30587-4-git-send-email-markmc@redhat.com \
    --to=markmc@redhat.com \
    --cc=aliguori@us.ibm.com \
    --cc=avi@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).