From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1M6M2s-0005nQ-QR for qemu-devel@nongnu.org; Tue, 19 May 2009 05:55:38 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1M6M2n-0005ie-JF for qemu-devel@nongnu.org; Tue, 19 May 2009 05:55:37 -0400 Received: from [199.232.76.173] (port=34887 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M6M2n-0005iI-BU for qemu-devel@nongnu.org; Tue, 19 May 2009 05:55:33 -0400 Received: from mail13.svc.cra.dublin.eircom.net ([159.134.118.29]:34269) by monty-python.gnu.org with smtp (Exim 4.60) (envelope-from ) id 1M6M2m-0006ei-P8 for qemu-devel@nongnu.org; Tue, 19 May 2009 05:55:33 -0400 From: Mark McLoughlin Date: Tue, 19 May 2009 10:55:24 +0100 Message-Id: <1242726931-5726-3-git-send-email-markmc@redhat.com> In-Reply-To: <1242726931-5726-2-git-send-email-markmc@redhat.com> References: <1242726931-5726-1-git-send-email-markmc@redhat.com> <1242726931-5726-2-git-send-email-markmc@redhat.com> Subject: [Qemu-devel] [PATCH 02/13] net: move the tap buffer into TAPState List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Mark McLoughlin , qemu-devel@nongnu.org KVM uses a 64k buffer for reading from tapfd (for GSO support) and allocates the buffer with TAPState rather than on the stack. Not allocating it on the stack probably makes sense for qemu anyway, so merge it in advance of GSO support. Signed-off-by: Mark McLoughlin --- net.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/net.c b/net.c index a819043..3f9062f 100644 --- a/net.c +++ b/net.c @@ -776,6 +776,7 @@ typedef struct TAPState { int fd; char down_script[1024]; char down_script_arg[128]; + uint8_t buf[4096]; } TAPState; static int launch_script(const char *setup_script, const char *ifname, int fd); @@ -827,12 +828,11 @@ static ssize_t tap_read_packet(int tapfd, uint8_t *buf, int maxlen) static void tap_send(void *opaque) { TAPState *s = opaque; - uint8_t buf[4096]; int size; - size = tap_read_packet(s->fd, buf, sizeof(buf)); + size = tap_read_packet(s->fd, s->buf, sizeof(s->buf)); if (size > 0) { - qemu_send_packet(s->vc, buf, size); + qemu_send_packet(s->vc, s->buf, size); } } -- 1.6.0.6