From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1M6NBw-00015o-6C for qemu-devel@nongnu.org; Tue, 19 May 2009 07:09:04 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1M6NBr-00012K-8E for qemu-devel@nongnu.org; Tue, 19 May 2009 07:09:03 -0400 Received: from [199.232.76.173] (port=36554 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M6NBr-00012H-4G for qemu-devel@nongnu.org; Tue, 19 May 2009 07:08:59 -0400 Received: from mx2.redhat.com ([66.187.237.31]:44721) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1M6NBq-0001qs-MG for qemu-devel@nongnu.org; Tue, 19 May 2009 07:08:58 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n4JB8vkN000400 for ; Tue, 19 May 2009 07:08:57 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n4JB8ub0025954 for ; Tue, 19 May 2009 07:08:57 -0400 Received: from localhost.localdomain (cleopatra.tlv.redhat.com [10.35.255.11]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n4JB8sbL032206 for ; Tue, 19 May 2009 07:08:55 -0400 From: Uri Lublin Date: Tue, 19 May 2009 14:08:53 +0300 Message-Id: <1242731333-1526-1-git-send-email-uril@redhat.com> Subject: [Qemu-devel] [PATCH] migrate.c: migrate_fd_put_buffer: Do not busyloop: stop writing if EWOULDBLOCK List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org The migration code is non-blocking, designed for live migration. Practically migrate_fd_put_buffer busy-loops trying to write, as on many machines EWOULDBLOCK==EAGAIN (look in include/asm-generic/errno.h). Signed-off-by: Uri Lublin --- migration.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/migration.c b/migration.c index 859d945..ca397fa 100644 --- a/migration.c +++ b/migration.c @@ -176,7 +176,7 @@ ssize_t migrate_fd_put_buffer(void *opaque, const void *data, size_t size) do { ret = s->write(s, data, size); - } while (ret == -1 && ((s->get_error(s)) == EINTR || (s->get_error(s)) == EWOULDBLOCK)); + } while (ret == -1 && ((s->get_error(s)) == EINTR)); if (ret == -1) ret = -(s->get_error(s)); -- 1.6.0.6