qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Glauber Costa <glommer@redhat.com>
To: qemu-devel@nongnu.org
Cc: Mark McLoughlin <markmc@redhat.com>, aliguori@us.ibm.com
Subject: [Qemu-devel] [PATCH STABLE 7/7] kvm: work around supported cpuid ioctl() brokenness
Date: Wed, 20 May 2009 15:36:18 -0300	[thread overview]
Message-ID: <1242844578-2647-8-git-send-email-glommer@redhat.com> (raw)
In-Reply-To: <1242844578-2647-7-git-send-email-glommer@redhat.com>

From: Mark McLoughlin <markmc@redhat.com>

KVM_GET_SUPPORTED_CPUID has been known to fail to return -E2BIG
when it runs out of entries. Detect this by always trying again
with a bigger table if the ioctl() fills the table.

Signed-off-by: Mark McLoughlin <markmc@redhat.com>
Signed-off-by: Glauber Costa <glommer@redhat.com>
---
 target-i386/kvm.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/target-i386/kvm.c b/target-i386/kvm.c
index 5b52de3..eb61598 100644
--- a/target-i386/kvm.c
+++ b/target-i386/kvm.c
@@ -44,6 +44,9 @@ static struct kvm_cpuid2 *try_get_cpuid(KVMState *s, int max)
     cpuid = (struct kvm_cpuid2 *)qemu_mallocz(size);
     cpuid->nent = max;
     r = kvm_ioctl(s, KVM_GET_SUPPORTED_CPUID, cpuid);
+    if (r == 0 && cpuid->nent >= max) {
+        r = -E2BIG;
+    }
     if (r < 0) {
         if (r == -E2BIG) {
             qemu_free(cpuid);
-- 
1.6.2.2

      reply	other threads:[~2009-05-20 18:36 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-20 18:36 [Qemu-devel] [PATCH STABLE 0/7] Glauber Costa
2009-05-20 18:36 ` [Qemu-devel] [PATCH STABLE 1/7] Introduce kvm_check_extension to check if KVM extensions are supported Glauber Costa
2009-05-20 18:36   ` [Qemu-devel] [PATCH STABLE 2/7] kvm: Add support for querying supported cpu features Glauber Costa
2009-05-20 18:36     ` [Qemu-devel] [PATCH STABLE 3/7] Make x86 cpuid feature names available in file scope Glauber Costa
2009-05-20 18:36       ` [Qemu-devel] [PATCH STABLE 4/7] Fix x86 feature modifications for features that set multiple bits Glauber Costa
2009-05-20 18:36         ` [Qemu-devel] [PATCH STABLE 5/7] kvm: Trim cpu features not supported by kvm Glauber Costa
2009-05-20 18:36           ` [Qemu-devel] [PATCH STABLE 6/7] Remove noisy printf when KVM masks CPU features Glauber Costa
2009-05-20 18:36             ` Glauber Costa [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1242844578-2647-8-git-send-email-glommer@redhat.com \
    --to=glommer@redhat.com \
    --cc=aliguori@us.ibm.com \
    --cc=markmc@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).