qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Glauber Costa <glommer@redhat.com>
To: qemu-devel@nongnu.org
Cc: aliguori@us.ibm.com
Subject: [Qemu-devel] [PATCH] run vnc without sdl
Date: Thu, 21 May 2009 14:21:19 -0400	[thread overview]
Message-ID: <1242930079-19798-1-git-send-email-glommer@redhat.com> (raw)

commit f92f8afebe038a4eae9ad90a140c9529f94919a6
"Eliminate --disable-gfx-check and make VNC default when SDL not available"
broke usage of vnc. Passing -vnc <something> now fails because it cannot initialize
SDL.

Signed-off-by: Glauber Costa <glommer@redhat.com>
---
 vl.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/vl.c b/vl.c
index e3cba75..74ad688 100644
--- a/vl.c
+++ b/vl.c
@@ -5977,7 +5977,7 @@ int main(int argc, char **argv, char **envp)
         } else
 #endif
 #if defined(CONFIG_SDL) || defined(CONFIG_COCOA)
-        if (sdl) {
+        if (sdl && !vnc_display) {
 #if defined(CONFIG_SDL)
             sdl_display_init(ds, full_screen, no_frame);
 #elif defined(CONFIG_COCOA)
-- 
1.5.6.6

             reply	other threads:[~2009-05-21 18:21 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-21 18:21 Glauber Costa [this message]
2009-05-21 21:58 ` [Qemu-devel] Re: [PATCH] run vnc without sdl Anthony Liguori
2009-05-21 22:19   ` Glauber Costa
2009-05-24 11:03   ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1242930079-19798-1-git-send-email-glommer@redhat.com \
    --to=glommer@redhat.com \
    --cc=aliguori@us.ibm.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).