From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1M7Ws7-0002DY-67
	for qemu-devel@nongnu.org; Fri, 22 May 2009 11:41:23 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1M7Ws2-00029J-Ab
	for qemu-devel@nongnu.org; Fri, 22 May 2009 11:41:22 -0400
Received: from [199.232.76.173] (port=34947 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1M7Ws2-000296-5f
	for qemu-devel@nongnu.org; Fri, 22 May 2009 11:41:18 -0400
Received: from moutng.kundenserver.de ([212.227.126.188]:50587)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <Laurent@vivier.eu>) id 1M7Ws1-00078V-I3
	for qemu-devel@nongnu.org; Fri, 22 May 2009 11:41:17 -0400
Subject: Re: [Qemu-devel] [PATCH] Add HTTP protocol using curl v7
From: Laurent Vivier <Laurent@vivier.eu>
In-Reply-To: <1243004222-27822-1-git-send-email-agraf@suse.de>
References: <1243004222-27822-1-git-send-email-agraf@suse.de>
Content-Type: text/plain; charset=utf-8
Date: Fri, 22 May 2009 17:41:07 +0200
Message-Id: <1243006867.5883.4.camel@Quad>
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>
Cc: qemu-devel@nongnu.org

Le vendredi 22 mai 2009 =C3=A0 16:57 +0200, Alexander Graf a =C3=A9crit :
> Currently Qemu can read from posix I/O and NBD. This patch adds a
> third protocol to the game: HTTP.
>=20
> In certain situations it can be useful to access HTTP data directly,
> for example if you want to try out an http provided OS image, but
> don't know if you want to download it yet.
>=20
> Using this patch you can now try it on on the fly. Just use it like:
>=20
> qemu -cdrom http://host/path/my.iso
>=20
> In order to not reinvent the wheel, this patch uses libcurl.
>=20
> Signed-off-by: Alexander Graf <agraf@suse.de>

Just a comment on the form: changelog should appear after the "---" with
diffstat to not be commited with the patch comment.
(they work like that on the linux kernel mailing list...)

> v2 changes:
>=20
> - fix the segfault (yay!)
> - implement AIO
>=20
> v3 changes:
>=20
> - remove synchronous API
> - implement caching
>=20
> v4 changes:
>=20
> - enable other protocols (HTTPS, FTP, FTPS, TFTP, SFTP, SCP)
>   (I only tested FTP so far, but they _should_ work)
>=20
> v5 changes:
>=20
> - address Anthony's comments
> - deactivate ssh protocols again
>=20
> v6 changes:
>=20
> - s/^I/        /g
> - s/http/curl/g
>=20
> v7 changes:
>=20
> - add Signed-off-by again
>=20
> ---
>  Makefile        |    6 +
>  Makefile.target |    2 +-
>  block-curl.c    |  540 +++++++++++++++++++++++++++++++++++++++++++++++++=
++++++
>  block.c         |   12 ++
>  block.h         |    7 +
>  configure       |   25 +++
>  6 files changed, 591 insertions(+), 1 deletions(-)
>  create mode 100644 block-curl.c
>=20
> diff --git a/Makefile b/Makefile
> index 3c70068..421cd41 100644
> --- a/Makefile
> +++ b/Makefile
[...]